Access instructor directly from endpoint #669
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toxantron
force-pushed
the
feat-endpoints
branch
from
bb1ad6c to
f5f3510
Compare
Toxantron
force-pushed
the
feat-endpoints
branch
from
f5f3510 to
c529d73
Compare
Toxantron
force-pushed
the
feat-endpoints
branch
from
c529d73 to
66b2da7
Compare
|
Still need to fix the tests. |
|
Nice – definitely one of the most unnecessary modules we've ever had 👍 Could we also harmonize the Namespaces |
dbeuchler
reviewed
Oct 8, 2025
Comment on lines
130
to
124
| public void AddInstruction(string identifier, InstructionModel instruction) | ||
| { | ||
| _workerSupport.AddInstruction(identifier, Converter.FromModel(instruction)); | ||
| } | ||
| var instructor = _resourceMgmt.GetResource<IVisualInstructionSource>(identifier); |
There was a problem hiding this comment.
What was the idea behind adding instructions from the endpoint?
Comment on lines
-30
to
-42
| var content = item.Content; | ||
| var preview = item.Preview; | ||
|
|
||
| // Apply content pattern | ||
| if (!string.IsNullOrEmpty(_config.ContentReplacement)) | ||
| { | ||
| // Fill content with content regex | ||
| if (_contentRegex != null && !string.IsNullOrEmpty(item.Content)) | ||
| item.Content = _contentRegex.Replace(content, _config.ContentReplacement); | ||
| // If replacement was configured but no regex, we apply the preview regex | ||
| else if (_previewRegex != null && !string.IsNullOrEmpty(item.Preview)) | ||
| item.Content = _previewRegex.Replace(preview, _config.ContentReplacement); | ||
| } |
There was a problem hiding this comment.
You have dropped the support for replacing regex - I don't really know, but was it an unused feature? I remember features like Instruction.Content = "<guid>|Master" which was then replaced by http://server/media/... - maybe we could move that to the VisualInstuctor itself?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module was introduced as part of the business and licensing model. Dropping it actually simplifies the endpoint.