Skip to content

Conversation

@lschoenepxc
Copy link
Contributor

Summary

Delete old CreatePackage flag, because it was not working anymore
Add IsPackable false if necessary (IsPackable true is the default)
Added a Directory.Build.props to the src/Tests directory to disable packaging for all test-projects in the directory

Review

Typical tasks

  • Merge-Request is well described
  • Critical sections are documented in code
  • Tests are extended
  • Documentation is created / updated
  • Running in test environment

Clean code

  • All unused references are removed
  • Clean code rules are respected with passion (naming, ...)
  • Avoid copy and pasted code snippets

@lschoenepxc lschoenepxc added the bug Something isn't working label Jun 28, 2023
@lschoenepxc lschoenepxc changed the title Delete CreatePackage flag and add IsPackable false, if necessary Switch CreatePackage flag with new IsPackable flag Jun 28, 2023
@1nf0rmagician 1nf0rmagician added this to the MoryxFramework 8.0.0 milestone Jun 29, 2023
@1nf0rmagician 1nf0rmagician merged commit 2c22f60 into PHOENIXCONTACT:future Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants