Skip to content

ReflectionResolver.Update automatically casts IConvertible-objects #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2021
Merged

ReflectionResolver.Update automatically casts IConvertible-objects #109

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1acc0aa
ReflectionResolver.Update automatically casts IConvertible-objects
Apr 28, 2021
6a11af3
Adjust typecheck in ReflectionResolver
Apr 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Moryx/Bindings/ReflectionResolver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ protected sealed override bool Update(object source, object value)
if (property == null || !property.CanWrite)
return false;

if (value is string && property.PropertyType.IsPrimitive)
if (value is IConvertible && property.PropertyType.GetInterfaces().Contains(typeof(IConvertible)) )
property.SetValue(source, Convert.ChangeType(value, property.PropertyType));
else
property.SetValue(source, value);
Expand Down
18 changes: 18 additions & 0 deletions src/Tests/Moryx.Tests/Bindings/ReflectionResolverTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// Copyright (c) 2020, Phoenix Contact GmbH & Co. KG
// Licensed under the Apache License, Version 2.0

using System;
using System.Reflection;
using Moryx.Bindings;
using NUnit.Framework;
Expand Down Expand Up @@ -63,6 +64,23 @@ public void AssignStringToInt()
Assert.AreEqual(int.Parse(number), obj.SimpleInt);
}

[Test]
public void AssignDoubleToString()
{
const double value = 7.78;

// Arrange
var obj = new SomeHiddenPropertyClass();
IBindingResolver reflectionResolver = new ReflectionResolver(nameof(SomeClass.SimpleString));

// Act
var result = reflectionResolver.Update(obj, value);

// Assert
Assert.IsTrue(result);
Assert.AreEqual(value, Convert.ToDouble(obj.SimpleString));
}

[Test(Description = "Checks if the reflection resolver returns null by resolving an unknown property")]
public void NullByUnknownProperty()
{
Expand Down