update resource monitoring for multilib

[PhilipDeegan]

fix some oversights

[coderabbitai]

📝 Walkthrough

Walkthrough

Refactored monitoring functions to remove cpplib parameter dependency by using direct pyphare.cpp module import and mpi_rank() for rank information. Updated all call sites in the simulator module to match new signatures. Added barrier synchronization before monitoring shutdown.

Changes

Cohort / File(s)	Summary
Monitoring Module Refactoring pyphare/pyphare/simulator/monitoring.py	Removed cpplib parameter from four function signatures (monitoring_yaml_file, setup_monitoring, monitoring_shutdown, timing_setup). Added import pyphare.cpp as cpp and replaced cpplib-based access with cpp.mpi_rank(). Added mpi_barrier() call in shutdown when stats manager exists; added error logging for timing directory creation failures.
Simulator Call Site Updates pyphare/pyphare/simulator/simulator.py	Updated make_cpp_simulator() and Simulator.run() to invoke monitoring functions without cpplib parameter. Modified setup_monitoring() call to derive interval from monitoring parameter (default 100 if non-integer).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• better timing directory creation #914: Modifies the same monitoring and timing setup integration in simulator call paths.

Suggested reviewers

• nicolasaunai

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	The description 'fix some oversights' is vague and generic, providing no meaningful information about what specific issues are being addressed in the changeset.	Provide a more descriptive explanation of which oversights are being fixed and why these monitoring function signature changes are necessary.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title relates to the changeset by mentioning resource monitoring updates, and the changes do refactor monitoring functions for multilib support by removing cpplib parameters and using cpp module directly.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

pyphare/pyphare/simulator/monitoring.py (1)

64-69: ⚠️ Potential issue | 🟡 Minor

FileNotFoundError is unlikely from Path.mkdir(parents=True, exist_ok=True).

With parents=True and exist_ok=True, mkdir won't raise FileNotFoundError. The realistic failure modes here are PermissionError or OSError (e.g., read-only filesystem). Consider catching a broader OSError instead.

Proposed fix

     try:
         Path(".phare/timings").mkdir(parents=True, exist_ok=True)
-    except FileNotFoundError:
+    except OSError:
         logger.error(f"Couldn't find timing dir from {os.getcwd() }")

🤖 Fix all issues with AI agents

In `@pyphare/pyphare/simulator/simulator.py`:
- Around line 202-203: The current check uses isinstance(monitoring, int) which
treats True as an int (1); change the logic so boolean True/False are not
treated as numeric intervals: explicitly detect and skip booleans (e.g., if
isinstance(monitoring, int) and not isinstance(monitoring, bool) or
alternatively check isinstance(monitoring, bool) first), then set interval =
monitoring only for real ints, otherwise default to 100; update the line that
assigns interval and keep the subsequent mon.setup_monitoring(interval) call
unchanged so mon.setup_monitoring gets the correct default when monitoring is
True.