Skip to content

fixed forbidden samrai Index to IntVector conversion #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolasaunai merged 3 commits into from
Dec 4, 2025
Merged

fixed forbidden samrai Index to IntVector conversion #1113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7caa514
fixed forbidden samrai Index to IntVector conversion
UCaromel Dec 2, 2025
027e867
update tests
PhilipDeegan Dec 3, 2025
b7ce5c2
Merge pull request #12 from PhilipDeegan/fix-samrai-intvector
UCaromel Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/amr/data/field/field_geometry.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,8 @@ namespace amr
static SAMRAI::hier::Box toFieldBox(SAMRAI::hier::Box box, PhysicalQuantity qty,
GridLayoutT const& layout)
{
SAMRAI::hier::IntVector lower = box.lower();
SAMRAI::hier::IntVector upper = box.upper();
auto const lower = box.lower();
auto const upper = box.upper();
using PHARE::core::dirX;
using PHARE::core::dirY;
using PHARE::core::dirZ;
Expand Down
4 changes: 2 additions & 2 deletions tests/amr/data/particles/copy_overlap/test_particledata_copy_periodicNd.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ struct twoParticlesDataNDTouchingPeriodicBorders : public testing::Test

bool overwriteInterior{true};

SAMRAI::hier::Transformation transformation{destPdat.getGhostBox().lower()
- sourceDomain.upper()};
SAMRAI::hier::Transformation transformation{
SAMRAI::hier::IntVector{destPdat.getGhostBox().lower() - sourceDomain.upper()}};

std::shared_ptr<SAMRAI::pdat::CellOverlap> cellOverlap{
std::dynamic_pointer_cast<SAMRAI::pdat::CellOverlap>(destGeom->calculateOverlap(
Expand Down
5 changes: 2 additions & 3 deletions tests/amr/data/particles/stream_pack/test_main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,8 @@ struct AParticlesData
bool overwriteInterior{true};

SAMRAI::hier::Index oneIndex{SAMRAI::hier::IntVector::getOne(amr_dimension)};

SAMRAI::hier::Transformation transformation{destDomain.lower() - sourceDomain.upper()
- oneIndex};
SAMRAI::hier::Transformation transformation{
SAMRAI::hier::IntVector{destDomain.lower() - sourceDomain.upper() - oneIndex}};


std::shared_ptr<SAMRAI::pdat::CellOverlap> cellOverlap{
Expand Down
Loading