Skip to content

MHD PR#1104

Open
UCaromel wants to merge 1 commit intoPHAREHUB:masterfrom
UCaromel:rebase-mhd-master
Open

MHD PR#1104
UCaromel wants to merge 1 commit intoPHAREHUB:masterfrom
UCaromel:rebase-mhd-master

Conversation

@UCaromel
Copy link
Contributor

@UCaromel UCaromel commented Nov 7, 2025

This PR is on top of current master, and includes of of the MHD additions. It is an updated version of #1070.

@coderabbitai
Copy link

coderabbitai bot commented Nov 7, 2025

Important

Review skipped

Too many files!

27 files out of 177 files are above the max files limit of 150.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.



class MHDModel(object):
def defaulter(self, input, value):

Check notice

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns Note

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@PhilipDeegan PhilipDeegan mentioned this pull request Nov 8, 2025
@UCaromel UCaromel force-pushed the rebase-mhd-master branch 2 times, most recently from 183367d to b8fc4ab Compare November 12, 2025 10:22
fixed small rebase issue

hyperres quickfix

hyper res quickfix

fixing ambiguous syntaxe

hyper res quickfix 2

ssprk4 hotfix

++
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants