-
Notifications
You must be signed in to change notification settings - Fork 39
[Accuracy diff No.74、75] Fix accuracy diff for paddle.unique_consecutive API #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your contribution! |
|
所以确定是:paddle api 与 torch api 设计上行为不一致,而不是 paddle api 精度有误 ? 请 @ccsuzzh 同学谨慎判断,前者才需要在 PaddleAPITest 处进行行为对齐,后者则需要在 PaddlePaddle 主库中修复~ |
根据report路径下ci_ce_cpu和ci_ce_gpu下的error log和本地测试复现,return_inverse的值是正确的只是shape与torch对不上 |
cangtianhuang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wanghuancoder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
修复精度问题
paddle.unique_consecutive
修改历程:
根据ci_ce_cpu和ci_ce_gpu下的error log,发现导致accuracy error报错的原因是因为返回的inverse shape与torch不一致,在PaddleAPITest中重写paddle.unique_consecutive的转换rule进行修复,并且建议增加三个case:
测试结果