Skip to content

GS/HW: fix int() to uint() in hlsl and glsl#14017

Merged
lightningterror merged 1 commit into
PCSX2:masterfrom
crashGG:fix-int-2-uint
Feb 18, 2026
Merged

GS/HW: fix int() to uint() in hlsl and glsl#14017
lightningterror merged 1 commit into
PCSX2:masterfrom
crashGG:fix-int-2-uint

Conversation

@crashGG
Copy link
Copy Markdown
Contributor

@crashGG crashGG commented Feb 15, 2026

fix int() to uint() in hlsl and glsl

Description of Changes

fix int() to uint() in hlsl and glsl

Rationale behind Changes

Resolving data range errors in int()

Suggested Testing Steps

Did you use AI to help find, test, or implement this issue or feature?

No.

Copy link
Copy Markdown
Contributor

@lightningterror lightningterror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to bump shader cache:

static constexpr u32 SHADER_CACHE_VERSION = 82;

Edit: Also forgot to do gl shader.

@crashGG
Copy link
Copy Markdown
Contributor Author

crashGG commented Feb 16, 2026

Need to bump shader cache:

static constexpr u32 SHADER_CACHE_VERSION = 82;

Edit: Also forgot to do gl shader.

done.

Comment thread bin/resources/shaders/opengl/tfx_fs.glsl Outdated
fix int()  2  uint() in hlsl and glsl

Update tfx_fs.glsl

ver add 1

changed to unsigned
Copy link
Copy Markdown
Contributor

@lightningterror lightningterror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only did a dump run on dx11 and was fine, also no gl llvmpipe warnings this time.

@lightningterror lightningterror merged commit 62c40f1 into PCSX2:master Feb 18, 2026
12 checks passed
@crashGG crashGG deleted the fix-int-2-uint branch February 18, 2026 06:53
Hancock33 added a commit to Hancock33/batocera.piboy that referenced this pull request Feb 22, 2026
--------------------------------------------------------------------------------------------------------
batocera-emulationstation.mk 9ad9c154f6630d4d156b234ac493eaeb1a380793 # Version: Commits on Feb 18, 2026
--------------------------------------------------------------------------------------------------------
Merge pull request #2080 from batocera-linux/update-checker-24h

2nd check of updates after 24h,

------------------------------------------------------------------------------------------------
batocera-es-piboy.mk 9ad9c154f6630d4d156b234ac493eaeb1a380793 # Version: Commits on Feb 18, 2026
------------------------------------------------------------------------------------------------
Merge pull request #2080 from batocera-linux/update-checker-24h

2nd check of updates after 24h,

----------------------------------------------------------------------------------------------
es-theme-carbon.mk 20aaa914aed9c32d0da5905d4bb3cd28b97ff5d1 # Version: Commits on Feb 17, 2026
----------------------------------------------------------------------------------------------
update tamagotchi,

------------------------------------------------------------------------------------------
duckstation.mk 5a7c8552560802287c9b64c9bd1b8fb9015fffd7 # Version: Commits on Feb 18, 2026
------------------------------------------------------------------------------------------
FullscreenUI: Use command/option key icons on MacOS

And the Windows icon on Windows.,

-------------------------------------------------------------------------------------
hatari.mk f3e09f346f9bb5e2824cd8450dca6d67d9cff12a # Version: Commits on Feb 18, 2026
-------------------------------------------------------------------------------------
Downgrade the Fedora CI Job to Fedora 41 to work-around SDL problem

The SDL in Fedora 42 / 43 is currently not usable for the Hatari CI

since the \dummy\ driver behaves in a bad way:

 libsdl-org/SDL#14872

Downgrade to Fedora 41 until the fix arrives in the latest versions

of Fedora.,

-----------------------------------------------------------------------------------------------
lindbergh-loader.mk 973cfb7058daa8109685631705742a4086295f29 # Version: Commits on Feb 18, 2026
-----------------------------------------------------------------------------------------------
refactor: delegate `strdup`'d command string buffer freeing to `compileShader` and remove a redundant free.,

--------------------------------------------------------------------------------------
openmsx.mk 447cbad34b79529600757955dfe2eefd6d62f4c4 # Version: Commits on Feb 18, 2026
--------------------------------------------------------------------------------------
T9769 introduces always only 1 delay cycle.

The subtype doesn't matter, as extensively tested by several people with

several tools.

Closes #989 (again).,

----------------------------------------------------
pcsx2.mk v2.7.128 # Version: Commits on Feb 18, 2026
----------------------------------------------------
- [GS/HW: fix int()  to  uint() in hlsl and glsl](PCSX2/pcsx2#14017)

-------------------------------------------------------------------------------------
ppsspp.mk 12762879e4eb821e6c26c41c9591475f83d014e3 # Version: Commits on Feb 18, 2026
-------------------------------------------------------------------------------------
Merge pull request #21278 from hrydgard/minor-ui

Minor UI tweaks,

------------------------------------------------------------
xenia.mk v1.0.2843-master # Version: Commits on Feb 18, 2026
------------------------------------------------------------
Windows release build for xenia-project/xenia@17bc5b4.

[GPU/D3D12] Remove now-unused typed shared memory descriptors

All usage instances changed to ByteAddressBuffer.

,

-------------------------------------------------------------------------------------------
xenia-canary.mk d9747704bedc4e691ba243bf399647b836ce493e # Version: Commits on Feb 18, 2026
-------------------------------------------------------------------------------------------
[XMA] Reserve headroom per decoded frame and account for it in gating

The 3-bit field at +24bit in DWORD 1 of the XMA context was named

subframe_skip_count but never actually used for skipping subframes.

Testing across multiple titles (PGR4, Halo Reach) shows the field

might control extra output buffer blocks that must be reserved per decoded

frame. Renaming the field to output_buffer_padding to reflect this

observed behavior and adding padding to the minimum output space threshold

Pdding blocks are reserved from the output budget after each frame is

fully consumed, preventing the decoder from overrunning the space

that the game expects to remain free.

This is still likely not entirely correct but reduces some of the

observed noise in current implementation.,

-------------------------------------------------------------------------------------------
xenia-native.mk d9747704bedc4e691ba243bf399647b836ce493e # Version: Commits on Feb 18, 2026
-------------------------------------------------------------------------------------------
[XMA] Reserve headroom per decoded frame and account for it in gating

The 3-bit field at +24bit in DWORD 1 of the XMA context was named

subframe_skip_count but never actually used for skipping subframes.

Testing across multiple titles (PGR4, Halo Reach) shows the field

might control extra output buffer blocks that must be reserved per decoded

frame. Renaming the field to output_buffer_padding to reflect this

observed behavior and adding padding to the minimum output space threshold

Pdding blocks are reserved from the output budget after each frame is

fully consumed, preventing the decoder from overrunning the space

that the game expects to remain free.

This is still likely not entirely correct but reduces some of the

observed noise in current implementation.,

-------------------------------------------------------------------------------------
ikemen.mk 3f74cdbfb506c0b23fd07d319e0391a7af6ff5ab # Version: Commits on Feb 18, 2026
-------------------------------------------------------------------------------------
style: fix code style issues with gofmt,

---------------------------------------------------------------
ruffle.mk nightly-2026-02-18 # Version: Commits on Feb 18, 2026
---------------------------------------------------------------
## What's Changed

* avm1, avm2: Make NetConnection.connect schema check case-insensitive by @danielhjacobs in ruffle-rs/ruffle#23041

* tests: Improve some tests by including output from Flash Player instead of Ruffle by @kjarosh in ruffle-rs/ruffle#23047

**Full Changelog**: ruffle-rs/ruffle@nightly-2026-02-17...nightly-2026-02-18,

---------------------------------------------------------------------------------------------
solarus-engine.mk 8ea727bb4ae84017744538983f8a98d6915d2a2b # Version: Commits on Feb 18, 2026
---------------------------------------------------------------------------------------------
Merge branch 'metallizer/1921-enemy-hurt-sound' into 'dev'

-----------------------------------------------------------------------------------------
rpi-eeprom.mk b24cc73fbf9352281e91f0a0b1bdbf7eb8d5c548 # Version: Commits on Feb 18, 2026
-----------------------------------------------------------------------------------------
help: copy-edit

Co-authored-by: Andrew Scheller <lurch@durge.org>,

----------------------------------------------------------------------------------------
rtl8852cu.mk d4163de3f901e746acd20322fc324d0a95ca66c1 # Version: Commits on Feb 17, 2026
----------------------------------------------------------------------------------------
Update README.md,

------------------------------------------------------------------------------------
box64.mk 857991c5006c4f8002a58275a40f84171cf268c2 # Version: Commits on Feb 18, 2026
------------------------------------------------------------------------------------
[WRAPPER] Added libunistring 5 as a synonym to unistring 2,

-----------------------------------------------------------------------------------------
catacombgl.mk d612911485a28178bcdbf7dd0ad5c68aeb672ddb # Version: Commits on Feb 18, 2026
-----------------------------------------------------------------------------------------
Add memory offsets for Catacomb Abyss v1.12 DOS saved games,

---------------------------------------------------------------------------------------
corsixth.mk c648d6c8aa73dbe45c0e65de3876e0af070c5f6d # Version: Commits on Feb 17, 2026
---------------------------------------------------------------------------------------
Fix save/load issues with palettes (#3234)

* Fix save/load issues with palettes

When removing from load_info they needed to be otherwise blocked from

saving. Also when loading an older save game it expected the palette to

be returned by the permanent function (load_info)

* Bump save version

Enough difference that it's probably worth a new version even without

afterLoad handling,

------------------------------------------------------------------------------------------
devilutionx.mk ed18290f28fd0c6689d5b055f21ef581f480bbc5 # Version: Commits on Feb 18, 2026
------------------------------------------------------------------------------------------
[Controller] improve character joystick movement (#8449),

------------------------------------------------------------------------------------------
fallout2-ce.mk a2505f8412ce4237a9374f88180c0373976c30f2 # Version: Commits on Feb 18, 2026
------------------------------------------------------------------------------------------
Deobfuscate audio/critter/heap.cc (#282)

Mechanical renames only,

---------------------------------------------------------------------------------------
openjazz.mk 1623df2953f4b72033c2fdb8ba8d8b416cfa67bd # Version: Commits on Feb 18, 2026
---------------------------------------------------------------------------------------
Prepare 20260218 release,

----------------------------------------------------------------------------------------
openmohaa.mk dfd9bd230c7fbe3cad1b9437160e578e8e8f1eaa # Version: Commits on Feb 17, 2026
----------------------------------------------------------------------------------------
fix(renderer): add missing surface* functions and alphagen identity,

---------------------------------------------------------------------------------------
mangohud.mk 9ebc85dfd1730a95f0334bf14151a02859aa9f97 # Version: Commits on Feb 18, 2026
---------------------------------------------------------------------------------------
fex: Fix compilation

ALIGN_POT has been removed from the mesa utils. Add our own alignment

helper to resolve compilation.,

-----------------------------------------------------------------------------------------
winetricks.mk 02af8ba21a6d2648f72b5601f8b8b73a1eeb9e64 # Version: Commits on Feb 18, 2026
-----------------------------------------------------------------------------------------
vcrun2026: Fix incorrect casing of downloaded executable,

----------------------------------------------------------------------------------------------------
sdl2-gamecontrollerdb.mk a050623bb0e35e3e0ba635c48faddecf42ff225c # Version: Commits on Feb 18, 2026
----------------------------------------------------------------------------------------------------
Add easysmx x20 (#923)

* Add EasySMX X20 to gamecontrollerdb.txt

* Remove crc

* Revert name and trigger axis

---------

Co-authored-by: Alynne <alviscera@gmail.com>,

----------------------------------------------------------------------------------------
retroarch.mk 4c2c0ac4742e3f2ed8db54076e935c767f72b6d9 # Version: Commits on Feb 18, 2026
----------------------------------------------------------------------------------------
Fix input_config_get_prefix rewrite goof,

--------------------------------------------------------------------------------------------
vpinball-next.mk 943ff3d55b8bcb6c6960c705025c13a757a0f36e # Version: Commits on Feb 17, 2026
--------------------------------------------------------------------------------------------
misc: fix incorrect mouse scale on MacOS (ThrowBallsAlwaysOn),

----------------------------------------------------------------------------------------
doomretro.mk e2de5ad56c6e6056b1ebbdd0363df3dbdbe98f37 # Version: Commits on Feb 18, 2026
----------------------------------------------------------------------------------------
Further work on per-column shadows

Previous commit broke lighting.,

----------------------------------------------------------------------------------
trx.mk a7f53b8f3662645b29ce2068abc7974fb44ec709 # Version: Commits on Feb 18, 2026
----------------------------------------------------------------------------------
objects/crocodile: add TR3 support

This defines the TR3 alligator, which is similar to TR1's type,

except it has no concept of converting to a land type.,

---------------------------------------------------------------------------------------------
libretro-citra.mk 737f977a4f86705cc8f53e897e0c54fe3c1a5a34 # Version: Commits on Feb 18, 2026
---------------------------------------------------------------------------------------------
Merge branch 'master' into warmenhoven/dev/azahar_libretro,

--------------------------------------------------------------------------------------------------
libretro-clownmdemu.mk 8acc145d479d34409c9104d0ed067d552eb066a2 # Version: Commits on Feb 18, 2026
--------------------------------------------------------------------------------------------------
Add support for RAM-based cheats.,

---------------------------------------------------------------------------------------------
libretro-fbneo.mk 8046cc52643861f9af98b563477de6243b4fdd9b # Version: Commits on Feb 18, 2026
---------------------------------------------------------------------------------------------
(libretro) update files,

-------------------------------------------------------------------------------------------------
libretro-geargrafx.mk eab917a72d18d0495d3816f1f2918f9f8aa53c1e # Version: Commits on Feb 18, 2026
-------------------------------------------------------------------------------------------------
Fix sync load rom method,

----------------------------------------------------------------------------------------------
libretro-ppsspp.mk 12762879e4eb821e6c26c41c9591475f83d014e3 # Version: Commits on Feb 18, 2026
----------------------------------------------------------------------------------------------
Merge pull request #21278 from hrydgard/minor-ui

Minor UI tweaks,

----------------------------------------------------------------------------------------------
libretro-stella.mk 30b15892eec8aac36075e07b2f719bf7ff494344 # Version: Commits on Feb 18, 2026
----------------------------------------------------------------------------------------------
Merge branch 'cart-eff-grizzards',

--------------------------------------------------------------------------------------------
slang-shaders.mk a630e9ca647690ef8a018609ecaeba6952e4f858 # Version: Commits on Feb 17, 2026
--------------------------------------------------------------------------------------------
Improve NTSC effect (#853)

* Make NTSC profile parameter continuous with fractional increments

* Add screen resolution parameter to switch between auto and native

* Add NTSC auto phase option

* Adjust colors for presets with NTSC effect,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants