GS/HW: Mask 16bit colours when blending is disabled #12512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
GS
GS: Direct3D 11
GS: OpenGL
GS: Vulkan
GS: Direct3D 12
GS: Metal
labels
JordanTheToaster
force-pushed
the
colorcolourful
branch
from
3822a17 to
08b4b19
Compare
Contributor
|
Varity of changes got slight improvements, around 265 dumps changed similar like the ones below:
|
lightningterror
approved these changes
Apr 11, 2025
JordanTheToaster
force-pushed
the
colorcolourful
branch
from
08b4b19 to
18a647d
Compare
JordanTheToaster
force-pushed
the
colorcolourful
branch
from
18a647d to
ef3d2bb
Compare
Hancock33
added a commit
to Hancock33/batocera.piboy
that referenced
this pull request
Apr 20, 2025
------------------------------------------------------------------------------------- azahar.mk 76a23e4c72376b6a66ea35c550f50ebaab061ed6 # Version: Commits on Apr 11, 2025 ------------------------------------------------------------------------------------- Revert \Removed seemingly redundant `isEnabled` overrides\ This reverts commit cd58ce998af1a4237e9b3ee15a13443bb0844a46., ------------------------------------------------------------------------------------------ dolphin-emu.mk 5285b1168a629e44c2fcc42664bf003dcf55019e # Version: Commits on Apr 11, 2025 ------------------------------------------------------------------------------------------ Merge pull request #13503 from sepalani/ip-top-perf IP/Top: Fix performance regression in GetInterfaceOpt, ------------------------------------------------------------------------------------------ duckstation.mk 32963c3f6a525acb36288e9436c45ba99478468e # Version: Commits on Apr 12, 2025 ------------------------------------------------------------------------------------------ Controller: Use string_view() for localised strings, -------------------------------------------------------------------------------------- flycast.mk 93f463296d55152a32289911c10b1d00084286d6 # Version: Commits on Apr 11, 2025 -------------------------------------------------------------------------------------- Fetch translations & Recreate libretro_core_options_intl.h, ----------------------------------------------------------------------------------------------- lindbergh-loader.mk 0e8b3b4a594b8070ee5c3ead5899c7dca7d51cc5 # Version: Commits on Apr 12, 2025 ----------------------------------------------------------------------------------------------- Merge pull request #92 from dkeruza-neo/master AppImage support., -------------------------------------------------------------------------------------- openmsx.mk 4179571cb770dbfcc5781d8333c05b79e9cec503 # Version: Commits on Apr 12, 2025 -------------------------------------------------------------------------------------- Updated softwaredb.xml with newest entries I accidentally kept SQL fields on that got added as XML nodes. Code has been fixed and works now as expected, ---------------------------------------------------- pcsx2.mk v2.3.265 # Version: Commits on Apr 12, 2025 ---------------------------------------------------- - [GS/HW: Mask 16bit colours when blending is disabled](PCSX2/pcsx2#12512) ------------------------------------------------------------------------------------- ppsspp.mk 8309e01c966b2a4201861c68400273994c12ee7d # Version: Commits on Apr 11, 2025 ------------------------------------------------------------------------------------- Merge pull request #20241 from hrydgard/show-achievement-type Show little indicators on achievements of the type, ------------------------------------------------------------------------------------ rpcs3.mk 9c5b3a2300b3ac44b897813ebc1cb0949c3b3e6d # Version: Commits on Apr 02, 2025 ------------------------------------------------------------------------------------ Update to Qt 6.9.0, --------------------------------------------------------------- ruffle.mk nightly-2025-04-12 # Version: Commits on Apr 12, 2025 --------------------------------------------------------------- ## What's Changed * ci: Build dual-wasm for selfhosted/demo/docs by @danielhjacobs in ruffle-rs/ruffle#20059 * build(deps-dev): bump vite from 6.2.5 to 6.2.6 in /web by @dependabot in ruffle-rs/ruffle#20064 **Full Changelog**: ruffle-rs/ruffle@nightly-2025-04-11...nightly-2025-04-12, --------------------------------------------------------------------------------------- thextech.mk 59c7de19b867c486fd8647e96632ee9278c5832c # Version: Commits on Apr 11, 2025 --------------------------------------------------------------------------------------- layers.cpp: fix v1.3.7 change to warp event timing (#945) (cherry picked from commit 99a0554eece9c7c6864399eb5022059a4b2fb78f), -------------------------------------------------------------------------------------- eduke32.mk b8759847124c2c53a165a02efef4a0c778674baf # Version: Commits on Apr 11, 2025 -------------------------------------------------------------------------------------- Fix `includeoptional` in Mapster32's sound parser ------------------------------------------------------------------------------------------- jazz2-native.mk 131bfbf0984a1116946c58d3eaf19a09e538e15f # Version: Commits on Apr 11, 2025 ------------------------------------------------------------------------------------------- Multiplayer, another fix for connect, ---------------------------------------------------------------------------------- stk.mk 0f6dbc741a455bb363427d5d3b3cd1637b8f13b9 # Version: Commits on Apr 10, 2025 ---------------------------------------------------------------------------------- Remove duplicated code in GEVulkanSkyBoxRenderer, ---------------------------------------------------------------------------------------- retroarch.mk 05adec60da8b319d1a137f138832936e46d9cd7b # Version: Commits on Apr 12, 2025 ---------------------------------------------------------------------------------------- Fetch translations from Crowdin, --------------------------------------------------------------------------------------- vpinball.mk 65a49677bdb987cf716b7e2c181661b6efb152af # Version: Commits on Jul 23, 2024 --------------------------------------------------------------------------------------- misc: standalone builds for macos, ios, tvos, android, linux, and rpi, ---------------------------------------------------------------------------------------- doomretro.mk 6d873efb4c0e52678d1028ea28fcf895e295882f # Version: Commits on Apr 11, 2025 ---------------------------------------------------------------------------------------- Separate removed thinkers, ----------------------------------------------------------------------------------- tr1x.mk 36ab43f0b3770a2fbd4253d85ab115e1571cf1fd # Version: Commits on Apr 11, 2025 ----------------------------------------------------------------------------------- tr2/option_passport: add new game options This adds NG+, Japanese, and Japanese NG+ options (as well as regular NG) to the new game page in the passport. Resolves #2731., ----------------------------------------------------------------------------------- tr2x.mk 36ab43f0b3770a2fbd4253d85ab115e1571cf1fd # Version: Commits on Apr 11, 2025 ----------------------------------------------------------------------------------- tr2/option_passport: add new game options This adds NG+, Japanese, and Japanese NG+ options (as well as regular NG) to the new game page in the passport. Resolves #2731., -------------------------------------------------------------------------------------------- libretro-dice.mk 67685b353e5499e0086d234f47aa352200c0be11 # Version: Commits on Apr 12, 2025 -------------------------------------------------------------------------------------------- Core no longer \experimental\, update download instructions., ----------------------------------------------------------------------------------------------- libretro-flycast.mk 93f463296d55152a32289911c10b1d00084286d6 # Version: Commits on Apr 11, 2025 ----------------------------------------------------------------------------------------------- Fetch translations & Recreate libretro_core_options_intl.h, ---------------------------------------------------------------------------------------------- libretro-ppsspp.mk 8309e01c966b2a4201861c68400273994c12ee7d # Version: Commits on Apr 11, 2025 ---------------------------------------------------------------------------------------------- Merge pull request #20241 from hrydgard/show-achievement-type Show little indicators on achievements of the type, --------------------------------------------------------------------------------------------- libretro-vba-m.mk 8936feaa716312ecc6cb52b59c80537340e961b2 # Version: Commits on Apr 11, 2025 --------------------------------------------------------------------------------------------- build: add libtiff to Nix derivation Signed-off-by: Rafael Kitover <[email protected]>,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Masks 16 bit colours when blending is disabled. Currently known to fix Need for Speed Carbon car colour compared to software.
Master Hardware:
Master Software:
PR Hardware:
Rationale behind Changes
The colours are incorrect and this is bad.
Suggested Testing Steps
Check any games you have and see if you spot an visual differences and also make sure nothing go boom.