Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for mip-cmor-tables #722

Merged
merged 14 commits into from
Jan 26, 2024
Merged

Updates for mip-cmor-tables #722

merged 14 commits into from
Jan 26, 2024

Conversation

mauzey1
Copy link
Collaborator

@mauzey1 mauzey1 commented Jan 16, 2024

Resolves #709, #718

  • CMOR will throw an error if it processes a JSON file that contains null values. Used to avoid segfaults.
  • When processing attributes in variable entries, any JSON list values will be converted into a space-separated lists string. Used for the dimensions and modeling_realm variable attributes.
  • Modeling realm strings were being split by spaces and only had the first word found stored in the realm attribute of the file. This has been fixed by storing the whole realm string.
  • Bumped version from 3.7.3 to 3.8.0 to allow for the use of mip-cmor-tables

Copy link
Contributor

@durack1 durack1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mauzey1 thanks!

@mauzey1
Copy link
Collaborator Author

mauzey1 commented Jan 17, 2024

I plan to incorporate a CMIP6Plus test into this PR that will also include having the mip-cmor-tables as a submodule. I will also need to bump the version number in order for CMOR to work with the mip-cmor-tables. Maybe CMOR 3.8.0a or something along those lines.

@durack1
Copy link
Contributor

durack1 commented Jan 17, 2024

I plan to incorporate a CMIP6Plus test into this PR that will also include having the mip-cmor-tables as a submodule. I will also need to bump the version number in order for CMOR to work with the mip-cmor-tables. Maybe CMOR 3.8.0a or something along those lines.

This sounds great to me. I figure that 3.8.0, 3.8.1+ will be pointing to the mip-cmor-tables, and prior versions have more hardcoded connections to the cmip6-cmor-tables, but have also been used with input4MIPs-cmor-tables and obs4MIPs-cmor-tables. So let's keep the versioning following the 3.8.x naming, rather than adding an additional identifier

@mauzey1 mauzey1 merged commit c2f7450 into main Jan 26, 2024
@mauzey1 mauzey1 deleted the 709-updates-for-mip-cmor-tables branch January 26, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

updates for mip-cmor-tables
2 participants