-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for mip-cmor-tables #722
Conversation
…low use of mip-cmor-tables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mauzey1 thanks!
I plan to incorporate a CMIP6Plus test into this PR that will also include having the mip-cmor-tables as a submodule. I will also need to bump the version number in order for CMOR to work with the mip-cmor-tables. Maybe CMOR 3.8.0a or something along those lines. |
This sounds great to me. I figure that 3.8.0, 3.8.1+ will be pointing to the mip-cmor-tables, and prior versions have more hardcoded connections to the cmip6-cmor-tables, but have also been used with input4MIPs-cmor-tables and obs4MIPs-cmor-tables. So let's keep the versioning following the 3.8.x naming, rather than adding an additional identifier |
Resolves #709, #718
null
values. Used to avoid segfaults.dimensions
andmodeling_realm
variable attributes.realm
attribute of the file. This has been fixed by storing the whole realm string.