458 switch from ossuuid to libuuid #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doutriaux1
reviewed
Apr 24, 2019
| - if [[ $CMOR_PYTHON_VERSION == '2.7' ]]; then conda create -q -n py2.7 -c cdat/label/nightly -c conda-forge -c cdat ossuuid udunits2 hdf5 libnetcdf numpy openssl lazy-object-proxy cdms2 python=2.7 $CONDA_COMPILERS testsrunner; fi | ||
| - if [[ $CMOR_PYTHON_VERSION == '3.6' ]]; then conda create -q -n py3.6 -c cdat/label/nightly -c conda-forge -c cdat ossuuid udunits2 hdf5 libnetcdf numpy openssl lazy-object-proxy cdms2 python=3.6 $CONDA_COMPILERS testsrunner; fi | ||
| - if [[ $CMOR_PYTHON_VERSION == '3.7' ]]; then conda create -q -n py3.7 -c cdat/label/nightly -c conda-forge -c cdat ossuuid udunits2 hdf5 libnetcdf numpy openssl lazy-object-proxy cdms2 python=3.7 $CONDA_COMPILERS testsrunner; fi | ||
| - if [[ $CMOR_PYTHON_VERSION == '2.7' ]]; then conda create -q -n py2.7 -c cdat/label/nightly -c conda-forge -c cdat libuuid udunits2 hdf5 libnetcdf numpy openssl lazy-object-proxy cdms2 python=2.7 $CONDA_COMPILERS testsrunner; fi |
There was a problem hiding this comment.
couldn't we replace all these lines with:
conda create -q -n py$CMOR_PYTHON_VERSION -c cdat/label/nightly -c conda-forge -c cdat libuuid udunits2 hdf5 libnetcdf numpy openssl lazy-object-proxy cdms2 python=$CMOR_PYTHON_VERSION $CONDA_COMPILERS testsrunner
There was a problem hiding this comment.
Using $CMOR_PYTHON_VERSION in the command doesn't work. I will try to fix that in another pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #458