refactor: make StringTable::lookup const#209
Merged
KowalskiThomas merged 1 commit intoP403n1x87:mainfrom Dec 8, 2025
Merged
Conversation
This was referenced Dec 8, 2025
KowalskiThomas
added a commit
to DataDog/dd-trace-py
that referenced
this pull request
Dec 8, 2025
## What does this PR do? This PR updates the `StringTable::lookup` method to be `const`. This required making the `std::mutex` we have `mutable`, which is OK – `mutable` is typically used for that. Additionally, it also makes the return type `std::reference_wrapper<const std::string>` as I don't think we should allow callers of `lookup` to change the underlying data, which the previous signature would allow. > [[cppreference]](https://en.cppreference.com/w/cpp/language/cv.html#mutable) mutable is used to specify that the member does not affect the externally visible state of the class (as often used for mutexes, memo caches, lazy evaluation, and access instrumentation). Echion PR: P403n1x87/echion#209
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the
StringTable::lookupmethod to beconst. This required making thestd::mutexwe havemutable, which is OK –mutableis typically used for that.Additionally, it also makes the return type
std::reference_wrapper<const std::string>as I don't think we should allow callers oflookupto change the underlying data, which the previous signature would allow.dd-trace-py PR: DataDog/dd-trace-py#15547