Add new events that allow for better API usage #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirSalad
requested changes
Apr 20, 2024
| import org.jetbrains.annotations.NotNull; | ||
|
|
||
| /** | ||
| * Called when a town has been created by a player. |
There was a problem hiding this comment.
"is about to be created" or similar
| public class TownCreateEvent extends TownPlayerEvent implements Cancellable { | ||
| private static final HandlerList HANDLERS = new HandlerList(); | ||
|
|
||
| private boolean cancelled; |
| import org.jetbrains.annotations.NotNull; | ||
|
|
||
| /** | ||
| * Called when a town has been disbanded by a player. |
|
|
||
| /** The player disbanding the town */ | ||
| private final Player player; | ||
| private boolean cancelled; |
| * Abstract event class for all town related events | ||
| */ | ||
| public abstract class TownEvent extends Event { | ||
| private final Town town; |
| import org.jetbrains.annotations.NotNull; | ||
|
|
||
| /** | ||
| * Called when a player left a town. |
There was a problem hiding this comment.
"is about to leave" or similar
| import org.jetbrains.annotations.NotNull; | ||
|
|
||
| /** | ||
| * Called when a player has joined a town. |
| * If you cancel the event in this case, nothing happens. | ||
| * </p> | ||
| */ | ||
| public class TownPlayerJoinEvent extends TownPlayerEvent implements Cancellable { |
There was a problem hiding this comment.
This should also be fired on com.oxywire.oxytowns.command.commands.admin.town.TownAddPlayerCommand
| /** | ||
| * Called when a town has been disbanded by a player. | ||
| */ | ||
| public class TownDisbandEvent extends TownPlayerEvent implements Cancellable { |
There was a problem hiding this comment.
This should also be fired on com.oxywire.oxytowns.command.commands.admin.town.TownDisbandCommand
| public class TownDisbandEvent extends TownPlayerEvent implements Cancellable { | ||
| private static final HandlerList HANDLERS = new HandlerList(); | ||
|
|
||
| /** The player disbanding the town */ |
There was a problem hiding this comment.
Do we need this context? Towns will only ever be naturally disbanded by the mayor or a server admin
|
Made the adjustments. Thanks for the feedback. I apologize for the long wait. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some new events and improves the event API