Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract light from ax3 #218

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Extract light from ax3 #218

wants to merge 2 commits into from

Conversation

angerhang
Copy link
Member

@angerhang angerhang commented Dec 1, 2022

  • Include lux extraction from ax3 to epoch file
  • Add dummy light variable to device readers without light
  • Include summary stat calculation for light

Test plan:

python accelerometer/accProcess.py data/hang.cwa --deleteIntermediateFiles False

Output:
Screenshot 2022-12-01 at 19 44 53

Screenshot 2022-12-02 at 14 16 17

This PR might break some of the regression tests as it adds a new column to the extracted files but won't know until the tests are finished. Oh well, will have to regenerate the other reference data format but can anyone review this PR before I regenerate the reference extraction files? :D

* Add dummy light variable to device readers without light
@aidendoherty
Copy link
Member

Would it be better to introduce this enhancement in Actipy rather than BBA @angerhang @chanshing ?

@angerhang
Copy link
Member Author

Would it be better to introduce this enhancement in Actipy rather than BBA @angerhang @chanshing ?

Great idea Aiden. I am not familiar with the Actipy codebase so not sure how to do that exactly. It is also not clear that for new feature, which repository to contribute to because Actipy doesn't have many features that BBA has. Having to duplicate code in two repository just double the efforts for any new changes unfortunately :(

Maybe, let's get merged in BBA first, then create an issue on Actipy to add the light extraction is the a good first step?

@chanshing
Copy link
Member

Thanks, Hang. I'll put it on my todo list to implement it in actipy also.

@chanshing
Copy link
Member

All looks good. I'll think about how to rename ax3_light and to distinguish it from light. Thanks a lot Hang!

@angerhang angerhang added the idle label Dec 19, 2022
@angerhang
Copy link
Member Author

This feature is put on hold until the actipy backend migration finishes sometime next month.

Will revisit this end of January.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants