remove Transform.rotate, rename reverseIcon to forward

Overman775 · Jun 5, 2020 · a196e0b · a196e0b
1 parent 4f3e895
commit a196e0b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 16 deletions.
diff --git a/example/lib/widgets/appbar/widget_app_bar.dart b/example/lib/widgets/appbar/widget_app_bar.dart
@@ -175,7 +175,7 @@ class _MyDrawer extends StatelessWidget {
                   ),
                   isLead
                       ? NeumorphicCloseButton()
-                      : NeumorphicBackButton(reversedIcon: true),
+                      : NeumorphicBackButton(forward: true),
                 ],
               ),
             ),

diff --git a/lib/src/widget/back_button.dart b/lib/src/widget/back_button.dart
@@ -1,5 +1,3 @@
-import 'dart:math' as math show pi;
-
 import 'package:flutter/material.dart';
 import 'package:flutter/widgets.dart';
 import 'package:flutter_neumorphic/flutter_neumorphic.dart';
@@ -8,14 +6,14 @@ class NeumorphicBackButton extends StatelessWidget {
   final VoidCallback onPressed;
   final NeumorphicStyle style;
   final EdgeInsets padding;
-  final bool reversedIcon;
+  final bool forward;
 
   const NeumorphicBackButton({
     Key key,
     this.onPressed,
     this.style,
     this.padding,
-    this.reversedIcon = false,
+    this.forward = false,
   }) : super(key: key);
 
   @override
@@ -25,9 +23,8 @@ class NeumorphicBackButton extends StatelessWidget {
       style: style,
       padding: padding,
       tooltip: MaterialLocalizations.of(context).backButtonTooltip,
-      child: reversedIcon
-          ? Transform.rotate(
-              angle: 180 * math.pi / 180, child: nThemeIcons.backIcon)
+      child: forward
+          ? nThemeIcons.forwardIcon
           : nThemeIcons.backIcon,
       onPressed: onPressed ?? () => Navigator.maybePop(context),
     );

diff --git a/lib/src/widget/close_button.dart b/lib/src/widget/close_button.dart
@@ -1,5 +1,3 @@
-import 'dart:math' as math show pi;
-
 import 'package:flutter/material.dart';
 import 'package:flutter/widgets.dart';
 import 'package:flutter_neumorphic/flutter_neumorphic.dart';
@@ -8,14 +6,12 @@ class NeumorphicCloseButton extends StatelessWidget {
   final VoidCallback onPressed;
   final NeumorphicStyle style;
   final EdgeInsets padding;
-  final bool reversedIcon;
 
   const NeumorphicCloseButton({
     Key key,
     this.onPressed,
     this.style,
     this.padding,
-    this.reversedIcon = false,
   }) : super(key: key);
 
   @override
@@ -25,10 +21,7 @@ class NeumorphicCloseButton extends StatelessWidget {
       style: style,
       padding: padding,
       tooltip: MaterialLocalizations.of(context).closeButtonTooltip,
-      child: reversedIcon
-          ? Transform.rotate(
-              angle: 180 * math.pi / 180, child: nThemeIcons.closeIcon)
-          : nThemeIcons.closeIcon,
+      child: nThemeIcons.closeIcon,
       onPressed: onPressed ?? () => Navigator.maybePop(context),
     );
   }
-Original file line number
+Diff line change
@@ Expand Up / @@ -175,7 +175,7 @@ class _MyDrawer extends StatelessWidget { @@
                       ),
                       isLead
                           ? NeumorphicCloseButton()
-                          : NeumorphicBackButton(reversedIcon: true),
+                          : NeumorphicBackButton(forward: true),
                     ],
                   ),
                 ),
@@ Expand Down @@