Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RequestMetricsBuilder.with_metric_attrs_from_req #179

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dtheodor
Copy link

@dtheodor dtheodor commented Oct 6, 2024

Adding a builder method with_metric_attrs_from_req that accepts a function to generate metric attributes from the request. Function has the same signature with and by default is util::metrics_attributes_from_request. Also exposing metrics_attributes_from_request since whoever wants to add additional attributes may want to reuse it and extend its result.

Fixes #171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuring metric attributes
1 participant