Skip to content

Better check_freq, complete anuclim#885

Merged
aulemahal merged 13 commits intomasterfrom
fix-538
Oct 29, 2021
Merged

Better check_freq, complete anuclim#885
aulemahal merged 13 commits intomasterfrom
fix-538

Conversation

@aulemahal
Copy link
Copy Markdown
Collaborator

@aulemahal aulemahal commented Oct 27, 2021

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
  • Documentation has been added / updated (for bug fixes / features)
  • HISTORY.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.
  • bumpversion patch has been called on this branch
  • The relevant author information has been added to .zenodo.json

What kind of change does this PR introduce?

  • Extends check_freq so we can create Indicator classes accepting more than one input freqs.
  • Creates a DailyWeeklyMonthly indicator subclass for use in the anuclim virtual modules.
  • Adds many missing metadata for the anuclim indicators.

EDIT:

  • When src_timestep is not given, it is inferred in Mssing classes.

Does this PR introduce a breaking change?

No.

Other information:

@aulemahal aulemahal requested a review from tlogan2000 October 27, 2021 19:05
@coveralls
Copy link
Copy Markdown

coveralls commented Oct 27, 2021

Pull Request Test Coverage Report for Build 1399680918

  • 48 of 50 (96.0%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 90.227%

Changes Missing Coverage Covered Lines Changed/Added Lines %
xclim/core/missing.py 2 3 66.67%
xclim/sdba/base.py 0 1 0.0%
Totals Coverage Status
Change from base Build 1399600752: 0.02%
Covered Lines: 12455
Relevant Lines: 13804

💛 - Coveralls

Comment thread xclim/data/anuclim.yml Outdated
Comment thread xclim/core/indicator.py Outdated
Comment thread xclim/data/anuclim.yml Outdated
aulemahal and others added 2 commits October 28, 2021 11:06
Co-authored-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
Comment thread xclim/core/indicator.py Outdated
Comment thread xclim/core/datachecks.py Outdated
Comment thread xclim/core/datachecks.py Outdated
Comment thread xclim/core/missing.py Outdated
Comment thread xclim/data/anuclim.yml Outdated
Comment thread xclim/data/anuclim.yml Outdated
Comment thread xclim/testing/tests/test_calendar.py
Comment thread xclim/testing/tests/test_calendar.py
Comment thread xclim/core/indicator.py
Comment thread HISTORY.rst Outdated
Comment thread xclim/core/calendar.py Outdated
Comment thread xclim/core/calendar.py
Comment thread xclim/core/indicator.py Outdated
aulemahal and others added 3 commits October 29, 2021 11:56
Co-authored-by: David Huard <huard.david@ouranos.ca>
Co-authored-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
@aulemahal aulemahal merged commit 7e9d52e into master Oct 29, 2021
@aulemahal aulemahal deleted the fix-538 branch October 29, 2021 17:07
@aulemahal aulemahal mentioned this pull request Nov 17, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

anuclim add docs / refactor / add indicators (?)

5 participants