Conversation
Pull Request Test Coverage Report for Build 1399680918
💛 - Coveralls |
abel-bzz
reviewed
Oct 28, 2021
abel-bzz
reviewed
Oct 28, 2021
Zeitsperre
reviewed
Oct 28, 2021
Co-authored-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
abel-bzz
reviewed
Oct 28, 2021
Zeitsperre
approved these changes
Oct 29, 2021
huard
approved these changes
Oct 29, 2021
Co-authored-by: David Huard <huard.david@ouranos.ca> Co-authored-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number) and pull request (:pull:number) has been added.bumpversion patchhas been called on this branch.zenodo.jsonWhat kind of change does this PR introduce?
check_freqso we can create Indicator classes accepting more than one input freqs.DailyWeeklyMonthlyindicator subclass for use in the anuclim virtual modules.EDIT:
src_timestepis not given, it is inferred inMssingclasses.Does this PR introduce a breaking change?
No.
Other information: