sdba - Workaround for QDM with multidimensionnal arrays #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2346
💛 - Coveralls |
huard
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
bumpversion (minor / major / patch)has been called on this branchgit push --tags)What kind of change does this PR introduce?
Fixes the interpolating error in QuantileDeltaMapping that occurred when hist/sim had extra dmensions (other than
time) and when a linear or cubic interpolation was used. xarray issue Interpolation with multiple mutlidimensional arrays sharing dims fails pydata/xarray#4463 provided the workaround (and is open in order to make the error message more explicir).Does this PR introduce a breaking change?
No.