Flaky test #3980#3
Closed
Otter-0x4ka5h wants to merge 0 commit into
Closed
Conversation
Otter-0x4ka5h
force-pushed
the
flaky-test#3980
branch
from
a63a77b to
1ebbe58
Compare
Otter-0x4ka5h
pushed a commit
that referenced
this pull request
Dec 19, 2025
…mands (otter-sec#4106) * feat(cli): add surfpool config and integration (#3) * wip * refactor: Simplify Surfpool configuration and enhance validator argument handling - Removed the SurfpoolConfig struct and related logic, simplifying the ValidatorType enum. - Updated the command processing to accept additional arguments for the validator. - Adjusted the localnet and test functions to handle Surfpool and Solana validators more effectively. - Improved logging management for Surfpool validator. * feat(cli): Enhance argument handling for Surfpool validator - Added support for additional arguments to be passed to the test runner and validator. - Updated command definitions to include `--args` and `--validator-args` options. - Improved handling of validator arguments in the `test` and `localnet` functions. - Ensured proper routing of arguments to Surfpool when no explicit validator arguments are provided. * refactor(cli): Update ValidatorType enum and streamline argument handling * feat(cli): Introduce Surfpool configuration with validator integration * feat(cli): enable tui startup to localnet and fix some typos * feat(cli): add runbooks startup check to wait for the deployment of the program then run the tests against the local environment * chore: remove debug print * refactor(cli): change flags to be compatible with surfpool cli, add the runbooks serialization struct to make a more robust verification when waiting for runbooks * fix(cli): Improve runbook execution handling to consider failures as completed * clean up runbook execution checking logic * augment surfpool config fields * remove `SURFPOOL_RPC_URL` const * `remote_rpc_url` -> `datasource_rpc_url` * use `DEFAULT_RPC_PORT` const * fix surfpool command * add/use workflow to install surfpool * specify surfpool cli version for CI * disable surfpool logs by default; allow configuring in anchor.toml * add timeout_minutes to setup surfpool * clean up action * allow too many arguments for localnet fn * bump surfpool version for CI * start surfpool instead of validator in ci * update run-test.sh * fix setup-surfpool cache * add `.surfpool` folder to gitignore for `anchor init` * fix: apply `--offline` flag by default for surfpool * only print message about surfpool logs if logs created * feat: add block production mode to Surfpool configuration * bump surfpool versions in CI * feat: add block production mode to surfpool config for ido-pool test * feat: add sleep functionality to log tests for improved reliability * fix: update program log messages to use dynamic identifiers for better clarity * fix: skip mut error test until LiteSVM issue is resolved * fix: update surfpool CLI version to 0.11.2 in workflow files * fix: refactor testValidateAssociatedToken calls to use confirmed commitment * fix: add surfpool block production mode configuration for errors test * fix: start surfpool in daemon mode for client/example test * fix: add block production mode configuration for surfpool for misc * lint * fix: add setup step for surfpool in reusable tests workflow * add sleep in run-test.sh to execute runbooks * disable check_surfpool call in run-test.sh --------- Co-authored-by: MicaiahReid <micaiahreid@gmail.com> * fix: Ensure proper quoting in cleanup calls and improve process termination logic * fix: Improve cleanup logic and enhance surfpool process management * fix: supply surfpool_config to cluster_url fn * fix(ci): ensure local bin path is added to GITHUB_PATH during Surfpool installation * ci: debug surfpool install * debug ci * ci: remove sudo from install --------- Co-authored-by: Arthur Bretas <158767751+BretasArthur1@users.noreply.github.com>
Otter-0x4ka5h
pushed a commit
that referenced
this pull request
Mar 25, 2026
…mands (otter-sec#4106) * feat(cli): add surfpool config and integration (#3) * wip * refactor: Simplify Surfpool configuration and enhance validator argument handling - Removed the SurfpoolConfig struct and related logic, simplifying the ValidatorType enum. - Updated the command processing to accept additional arguments for the validator. - Adjusted the localnet and test functions to handle Surfpool and Solana validators more effectively. - Improved logging management for Surfpool validator. * feat(cli): Enhance argument handling for Surfpool validator - Added support for additional arguments to be passed to the test runner and validator. - Updated command definitions to include `--args` and `--validator-args` options. - Improved handling of validator arguments in the `test` and `localnet` functions. - Ensured proper routing of arguments to Surfpool when no explicit validator arguments are provided. * refactor(cli): Update ValidatorType enum and streamline argument handling * feat(cli): Introduce Surfpool configuration with validator integration * feat(cli): enable tui startup to localnet and fix some typos * feat(cli): add runbooks startup check to wait for the deployment of the program then run the tests against the local environment * chore: remove debug print * refactor(cli): change flags to be compatible with surfpool cli, add the runbooks serialization struct to make a more robust verification when waiting for runbooks * fix(cli): Improve runbook execution handling to consider failures as completed * clean up runbook execution checking logic * augment surfpool config fields * remove `SURFPOOL_RPC_URL` const * `remote_rpc_url` -> `datasource_rpc_url` * use `DEFAULT_RPC_PORT` const * fix surfpool command * add/use workflow to install surfpool * specify surfpool cli version for CI * disable surfpool logs by default; allow configuring in anchor.toml * add timeout_minutes to setup surfpool * clean up action * allow too many arguments for localnet fn * bump surfpool version for CI * start surfpool instead of validator in ci * update run-test.sh * fix setup-surfpool cache * add `.surfpool` folder to gitignore for `anchor init` * fix: apply `--offline` flag by default for surfpool * only print message about surfpool logs if logs created * feat: add block production mode to Surfpool configuration * bump surfpool versions in CI * feat: add block production mode to surfpool config for ido-pool test * feat: add sleep functionality to log tests for improved reliability * fix: update program log messages to use dynamic identifiers for better clarity * fix: skip mut error test until LiteSVM issue is resolved * fix: update surfpool CLI version to 0.11.2 in workflow files * fix: refactor testValidateAssociatedToken calls to use confirmed commitment * fix: add surfpool block production mode configuration for errors test * fix: start surfpool in daemon mode for client/example test * fix: add block production mode configuration for surfpool for misc * lint * fix: add setup step for surfpool in reusable tests workflow * add sleep in run-test.sh to execute runbooks * disable check_surfpool call in run-test.sh --------- Co-authored-by: MicaiahReid <micaiahreid@gmail.com> * fix: Ensure proper quoting in cleanup calls and improve process termination logic * fix: Improve cleanup logic and enhance surfpool process management * fix: supply surfpool_config to cluster_url fn * fix(ci): ensure local bin path is added to GITHUB_PATH during Surfpool installation * ci: debug surfpool install * debug ci * ci: remove sudo from install --------- Co-authored-by: Arthur Bretas <158767751+BretasArthur1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.