[rollout] fix: add missing orjson runtime dependency - #255
Merged
Conversation
JoyboyBrian
marked this pull request as ready for review
July 13, 2026 05:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
orjson>=3.11.6,<4.0as a direct SDK runtime dependency for tool-enabled rollout calls across local and remote backends.uv.lock, resolvingorjson==3.11.9.Why
Tool-enabled rollout calls can fail on any backend that installs the base SDK dependency set without separately installing
orjson. This affected bothLocalBackendand Harbor/Daytona sandbox execution, failing withlitellm.APIConnectionError: OpenAIException - No module named 'orjson'.LiteLLM imports
LiteLLM_Proxy_MCP_Handlerwhenever a completion contains anytools(v1.92.0 source). LiteLLM PR #31576 added a top-levelLiteLLMProxyRequestSetupimport to that handler (commit), which importshttp_parsing_utilsand thereforeorjsonat module load time. LiteLLM still declaresorjsononly under itsproxyoptional extra (pyproject.toml), so a base LiteLLM installation can reach this runtime path without havingorjsoninstalled.Declaring
orjsondirectly with LiteLLM's existing version bound makes the SDK dependency set complete for tool-enabled rollout calls across local and remote backends. Addingorjsonto the rollout image also unblocked the failed remote evaluation and artifact collection, confirming that the dependency gap—not artifact persistence—caused that incident.How to Test
uv lock --checkuv run --locked --extra dev ruff check .uv run --locked --extra dev ruff format --check .uv run --locked --extra dev pyright osmosis_ai/uv run --locked --extra dev pytest -quv build --wheel --out-dir /tmp/osmosis-sdk-orjson-distunzip -p /tmp/osmosis-sdk-orjson-dist/*.whl '*/METADATA' | rg '^Requires-Dist: orjson'Checklist
[module] type: descriptionformatbug,rollout,dependencies)ruff check .andruff format --check .passpyright osmosis_ai/passespytestpasses (1607 passed)