Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add notch support for iOS. #44

Merged
merged 1 commit into from
Nov 20, 2021
Merged

feat: add notch support for iOS. #44

merged 1 commit into from
Nov 20, 2021

Conversation

DeVoresyah
Copy link
Member

Notch Processor

Special thanks to @ptelad who made an awesome and helpful iPhone Notch Helper.

We just added notch syntax support in OsmiCSX.

Example Input

apply('flex m-5 notch:mt-10')

Example Output

Output style on Android:

{
  flex: 1,
  margin: 20
}

Output style on iOS & if has a notch:

{
  flex: 1,
  margin: 20,
  marginTop: 40,
}

@DeVoresyah DeVoresyah added enhancement New feature or request core All about core and main algorithm labels Nov 19, 2021
Copy link
Contributor

@ambrizals ambrizals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!!!

@DeVoresyah DeVoresyah merged commit 59a19b9 into development Nov 20, 2021
@DeVoresyah DeVoresyah deleted the feature/notch branch November 20, 2021 16:18
@DeVoresyah DeVoresyah mentioned this pull request Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core All about core and main algorithm enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants