Provide a useful error message when the same named parameter is provi…

…ded multiple times.
Orvid · Sep 29, 2023 · 6378be5 · 6378be5
1 parent 07f8f63
commit 6378be5
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/Caprica/papyrus/expressions/PapyrusFunctionCallExpression.cpp b/Caprica/papyrus/expressions/PapyrusFunctionCallExpression.cpp
@@ -413,7 +413,13 @@ void PapyrusFunctionCallExpression::semantic(PapyrusResolutionContext* ctx, Papy
               auto a = *iter;
               ++iter;
               a->argIndex = p->index;
-              newArgs.insertBefore(newArgsIter, a);
+              if (newArgsIter != newArgs.endInsertable() && idEq(newArgsIter->name, a->name)) {
+                ctx->reportingContext.error(a->value->location,
+                                            "Duplicate named parameter provided '{}'!",
+                                            a->name);
+              } else {
+                newArgs.insertBefore(newArgsIter, a);
+              }
               goto ContinueOuterLoop;
             }
             if (newArgsIter != newArgs.endInsertable() && newArgsIter->argIndex <= p->index)