-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dockerfile, use gr-gsm pre GNU Radio 3.8 #152
base: master
Are you sure you want to change the base?
Fix dockerfile, use gr-gsm pre GNU Radio 3.8 #152
Conversation
also requirements.txt for pip (not necessary in docker)
38b6033
to
4c96e40
Compare
Why did you chose this commit https://gitea.osmocom.org/sdr/gr-gsm/commit/fa184a9447a90aefde2ca0dea1347b702551015d and not last ? |
I seem to have overlooked that you found your own solution to running simple_IMSI-catcher.py with GNU-Radio 3.8 - so I guess this isn't necessary. I had a plethora of issues between last night and this morning, gsrm_livemon wouldn't run, complained about gnu-radio. Sorry for the lack of detail, I'm at work and on my windows partition, so I can't check atm. As @microwaven noticed in the issue I referenced - later versions of gr-gsm require 3.8, and this software was not cooperating, so I tied it down to that commit (That commit is the last one before GNU-radio 3.8 support was added) I can get your more detail later, or I may find that I was sleep deprived and this is dumb hacky fix to a problem that already has a much more elegant solution. TBD |
Right, here's what happened on my system running docker build. docker version
Uname
First run at docker build:
Fix in my case was to change to last commit before "GNU Radio 3.8 support" (was change I23dd638c8c48ed0a4b50559ce33fbd5e60b7dcbc) So I rolled back to gr-gsm @ fa184a9447a90aefde2ca0dea1347b702551015d Then in the docker bash there was no python3, so I added that. I'm not sure for what I added distutils, but I didn't need it for anything I tested today. And I believe I referenced #74 because of @microwaven comment about the readme, but after reflection I don't think it was actually related to the root issue there, so not a fix for that. |
I didn't have time to work on this :-( Line 1 in 34d68e5
|
Since #74 has been open for 2 years now, and I kinda doubt anyone is working on updating the actual software to 3.8, at least this will function.
Don't put it in master if there are plans to update?