Switch to transaction converter runtime api#28
Merged
NZT48 merged 2 commits intoOriginTrail:feature/frontierfrom Jul 15, 2022
Merged
Switch to transaction converter runtime api#28NZT48 merged 2 commits intoOriginTrail:feature/frontierfrom
NZT48 merged 2 commits intoOriginTrail:feature/frontierfrom
Conversation
JoshOrndorff
commented
Jul 15, 2022
Comment on lines
+873
to
+879
| impl fp_rpc::ConvertTransactionRuntimeApi<Block> for Runtime { | ||
| fn convert_transaction(transaction: EthereumTransaction) -> <Block as BlockT>::Extrinsic { | ||
| UncheckedExtrinsic::new_unsigned( | ||
| pallet_ethereum::Call::<Runtime>::transact { transaction }.into(), | ||
| ) | ||
| } | ||
| } |
Author
There was a problem hiding this comment.
Basically if you need the backwards compatibility, this is the only change you need.
Contributor
|
Thanks for helping @JoshOrndorff, old transaction converter implementation is not in production, so I guess there are no changes required :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reflects the changes from polkadot-evm/frontier#559
I've taken the simpler approach that entirely removes the old hard-coded converter. But if this code is already used in production, you need to restore that converter and provide it on the client side as well.