json updates to 6 files in public/schemas#88
json updates to 6 files in public/schemas#88wanderingstan merged 2 commits intoOriginProtocol:masterfrom nsimon:master
Conversation
… no schema with key or ref (ajv.js:95)'
… no schema with key or ref (ajv.js:95)'
|
More (possibly helpful) info. "Error: no schema with key or ref" -- was thrown when I clicked the Continue button to add an item. |
|
Hey @wanderingstan just FYI I helped Neil put this PR together. I'm not sure on the content of this PR. It seems right on the surface but I don't know enough about the JSON schema stuff just yet to be sure. I mostly just wanted to help Neil to go through the process of submitting a PR. Let us both know what you think when you get around to it. |
|
To shed some more light on why this error was happening, FWIW: If you look at our package-lock.json, you'll see that we have a couple packages that have the All that to say, this fix looks good. 😃 |
|
Thanks. and great explanation Tyler! I also saw the |
|
Thanks for this, @nsimon ! |
|
Hey @wanderingstan glad I could help! |
Updated $schema":"http://json-schema.org/draft-04/schema#" to
"$schema":"http://json-schema.org/draft-06/schema#"
Changed types on all min/max field values from string to integer.
Original draft-04 was throwing an error in my linux Firefox (v58.0.2) dev console:
"Error: no schema with key or ref".
I changed the source json $schema values to use draft-06, and then saw a more useful error message. Can't recall the exact error syntax, but it referred to all of the min/max fields being invalid string types, which I then fixed to be integers. That solved the issue.
I suspect the original draft-04 schemas were working in other os/browser environments, due to a less stringent JVM running in those browsers. Perhaps the linux Firefox JVM was less forgiving?
Neil