Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Add CORS_WHITELIST for setting CORS in @origin/token-transfer-server #4548

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yujie0505
Copy link

Description:

The whitelist of host names for CORS is hard-coded when deploying to the Heroku. So, I need to have another environment variable to set this whitelist without changing anything in the codebase.

Checklist:

@franckc franckc requested a review from tomlinton May 13, 2021 06:01
@tomlinton
Copy link
Contributor

I think you can just make this change locally, we don't need to merge it into our codebase?

@yujie0505
Copy link
Author

yujie0505 commented May 14, 2021

Yes, I could just change it locally to resolve this issue. However, I'd like to submit this PR for the following reasons:

  1. I was stuck in the CORS error because I thought CLIENT_URL would be used for the accepted hosts in the beginning.
  2. After reading README, I could not find anything else for me to set the accepted hosts, so I needed to trace code to resolve it.
  3. I think that if someone in the community is interested in deploying the t3-server for himself, then this PR will save his time not to stuck in the same error and to focus on something interesting.

Many thanks~

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants