-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deposit front-running checks before staking to validators #2311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naddison36
requested review from
sparrowDom,
DanielVF,
shahthepro and
clement-ux
as code owners
November 19, 2024 03:47
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2311 +/- ##
==========================================
- Coverage 53.26% 52.19% -1.08%
==========================================
Files 79 79
Lines 4098 4098
Branches 1079 1079
==========================================
- Hits 2183 2139 -44
- Misses 1912 1956 +44
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
…dy in the contract
naddison36
changed the title
Validator balance checks before deposit
Deposit front-running checks before staking
Nov 21, 2024
naddison36
changed the title
Deposit front-running checks before staking
Deposit front-running checks before staking to validators
Nov 21, 2024
shahthepro
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
snapValidators
Hardhat taskCode Change Checklist
To be completed before internal review begins:
Internal review: