Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deposit front-running checks before staking to validators #2311

Merged
merged 12 commits into from
Nov 25, 2024

Conversation

naddison36
Copy link
Collaborator

@naddison36 naddison36 commented Nov 19, 2024

Changes

  • Added snapValidators Hardhat task
  • Added third staking strategy to Defender Actions
  • Added check for deposit front-running in Defender Action that does the staking
  • Updated OETH contracts diagram
  • Fix native staking fork tests when there are a lot of consensus rewards in the strategy

Code Change Checklist

To be completed before internal review begins:

  • The contract code is complete
  • Executable deployment file
  • Fork tests that test after the deployment file runs
  • Unit tests *if needed
  • The owner has done a full checklist review of the code + tests

Internal review:

  • Two approvals by internal reviewers

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.19%. Comparing base (adf36d1) to head (ae2e4d7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2311      +/-   ##
==========================================
- Coverage   53.26%   52.19%   -1.08%     
==========================================
  Files          79       79              
  Lines        4098     4098              
  Branches     1079     1079              
==========================================
- Hits         2183     2139      -44     
- Misses       1912     1956      +44     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@naddison36 naddison36 marked this pull request as draft November 19, 2024 12:38
@naddison36 naddison36 changed the title Validator balance checks before deposit Deposit front-running checks before staking Nov 21, 2024
@naddison36 naddison36 marked this pull request as ready for review November 21, 2024 12:15
@naddison36 naddison36 changed the title Deposit front-running checks before staking Deposit front-running checks before staking to validators Nov 21, 2024
@naddison36 naddison36 merged commit 4366552 into master Nov 25, 2024
15 of 21 checks passed
@naddison36 naddison36 deleted the nicka/val_bal_check branch November 25, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants