Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#87] Update value for opacity800 #88

Merged
merged 3 commits into from
Sep 12, 2024
Merged

[#87] Update value for opacity800 #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd65c01
fix: update `opacity800` from `0.88` to `0.80` (#87) (#86)
julien-deramond Sep 10, 2024
67d4c38
test: add missing unit tests for opacity raw tokens
pylapp Sep 10, 2024
0332b8d
chore: update CHANGELOG
pylapp Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed

- [Library] "OUDSThemesCommons" product has been renamed to "OUDS"
- [Library] Update value of opacity raw token "opacity800" from 0.88 to 0.80 ([#87](https://github.com/Orange-OpenSource/ouds-ios/issues/87))
- [Library] Add missing unit tests for opacity raw tokens

### Fixed

Expand Down
2 changes: 1 addition & 1 deletion OUDS/Core/Tokens/RawTokens/Sources/OpacityRawTokens.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,6 @@ public enum OpacityRawTokens {
public static let opacity500: OpacityRawToken = 0.32
public static let opacity600: OpacityRawToken = 0.48
public static let opacity700: OpacityRawToken = 0.64
public static let opacity800: OpacityRawToken = 0.88
public static let opacity800: OpacityRawToken = 0.80
public static let opacity900: OpacityRawToken = 1
}
4 changes: 4 additions & 0 deletions OUDS/Core/Tokens/RawTokens/Tests/OpacityRawTokensTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,8 @@ final class OpacityRawTokensTests: XCTestCase {
func testOpacityRawToken700LessThan800() throws {
XCTAssertLessThan(OpacityRawTokens.opacity700, OpacityRawTokens.opacity800)
}

func testOpacityRawToken800LessThan900() throws {
XCTAssertLessThan(OpacityRawTokens.opacity800, OpacityRawTokens.opacity900)
}
}