Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(opacity): update opacity800 from 0.88 to 0.80 #86

Merged
merged 1 commit into from
Sep 10, 2024
Merged

feat(opacity): update opacity800 from 0.88 to 0.80 #86

merged 1 commit into from
Sep 10, 2024

Conversation

julien-deramond
Copy link
Contributor

@julien-deramond julien-deramond commented Sep 10, 2024 •
edited by pylapp
Loading

Related issues

Closes #87

Description

This PR updates the value of opacity800 from 0.88 to 0.80 following the modification in Figma tokens.

Types of change

  • New feature (non-breaking change which adds functionality)

Previews

Checklist

Contribution

Accessibility

  • (N/A) My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I have added unit tests to cover my changes (optional)

Documentation

  • (N/A) My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • (N/A) Design review has been done
  • (N/A) Accessibiltiy review has been done
  • (N/A) Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues

@pylapp pylapp self-assigned this Sep 10, 2024
@pylapp pylapp mentioned this pull request Sep 10, 2024
Closed
@pylapp pylapp changed the base branch from develop to 86-update-opacity800 September 10, 2024 07:33
pylapp
pylapp approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@pylapp pylapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pylapp
Copy link
Member

pylapp commented Sep 10, 2024

An issue was missing for this fix, thus I create #87.
I changed also the destination branch for the pull request so that I can update the CHANGELOG (and add a missing unit test I spotted but not related to your fix, just another case to test). I ensured before your branch compiled and any tests were still green :)

@pylapp pylapp merged commit 44a6442 into Orange-OpenSource:86-update-opacity800 Sep 10, 2024
1 of 3 checks passed
@pylapp pylapp mentioned this pull request Sep 10, 2024
Merged
9 tasks
@julien-deramond julien-deramond deleted the develop-jd-update-opacity-800-raw-token branch September 10, 2024 08:15
pylapp pushed a commit that referenced this pull request Sep 12, 2024
@julien-deramond @pylapp
fix: update opacity800 from 0.88 to 0.80 (#87) (#86)
bd65c01
pylapp added a commit that referenced this pull request Sep 12, 2024
@pylapp @julien-deramond
fix: value for raw token opacity800 (#86)(#88)
8331d0d 
Closes #86 

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Co-authored-by: Julien Déramond <[email protected]>
Co-authored-by: Pierre-Yves Lapersonne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pylapp pylapp pylapp approved these changes

@ludovic35 ludovic35 Awaiting requested review from ludovic35

Assignees

@pylapp pylapp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tokens] Update value for opacity800
2 participants
@julien-deramond @pylapp