-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#159] Create button component #397
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
3ff2e08
to
6a0a1fa
Compare
4a8d927
to
4e7a324
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je me suis permis pour gagner du temps et nous permettre d'avancer plus vite, de corriger quelques fautes de frappe et d'améliorer la documentation après avoir fait un rebase de la branche avant la relecture du code.
C'est bon pour moi, néanmoins il manque les tests UI sur les boutons.
Tant que ces tests ne seront pas implémentés on ne pourra merger pull request.
J'ai également pris en charge l'option d'a11y servant à désactiver les animations concernant l'état loading du bouton.
OUDS/Core/Components/Sources/Buttons/Internal/OUDSButtonStyle+LoadingModifiers.swift
Show resolved
Hide resolved
OUDS/Core/Components/Sources/Buttons/Internal/OUDSButtonStyle+LoadingModifiers.swift
Outdated
Show resolved
Hide resolved
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
3fbd34b
to
83b95d6
Compare
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
83b95d6
to
bf72f58
Compare
Note: Please transform
- [ ]
into- (NA)
in the description when things are not applicableRelated issues
#159
Description
Implementation of button
Motivation & Context
Types of change
Previews
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)