Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#159] Create button component #397

Draft
wants to merge 31 commits into
base: develop
Choose a base branch
from

Conversation

ludovic35
Copy link
Member

@ludovic35 ludovic35 commented Jan 16, 2025

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

#159

Description

Implementation of button

Motivation & Context

Types of change

  • New feature (non-breaking change which adds functionality)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I checked my changes do not add new SwiftLint warnings
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • Design review has been done
  • Accessibiltiy review has been done
  • Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues
  • The wiki has been updated if needed (optional)

@ludovic35 ludovic35 linked an issue Jan 16, 2025 that may be closed by this pull request
@ludovic35 ludovic35 changed the title 159 component create button component [#159] Create button component Jan 16, 2025
pylapp and others added 27 commits January 17, 2025 14:55
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp pylapp force-pushed the 159-component-create-button-component branch from 3ff2e08 to 6a0a1fa Compare January 17, 2025 14:33
@pylapp pylapp force-pushed the 159-component-create-button-component branch 2 times, most recently from 4a8d927 to 4e7a324 Compare January 17, 2025 17:31
Copy link
Member

@pylapp pylapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je me suis permis pour gagner du temps et nous permettre d'avancer plus vite, de corriger quelques fautes de frappe et d'améliorer la documentation après avoir fait un rebase de la branche avant la relecture du code.

C'est bon pour moi, néanmoins il manque les tests UI sur les boutons.
Tant que ces tests ne seront pas implémentés on ne pourra merger pull request.

J'ai également pris en charge l'option d'a11y servant à désactiver les animations concernant l'état loading du bouton.

@pylapp pylapp self-assigned this Jan 17, 2025
@pylapp pylapp force-pushed the 159-component-create-button-component branch from 3fbd34b to 83b95d6 Compare January 17, 2025 17:45
@pylapp pylapp force-pushed the 159-component-create-button-component branch from 83b95d6 to bf72f58 Compare January 17, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Component] Create component - Button
2 participants