Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#79] New architcture with tokens wrapper #352

Merged
merged 36 commits into from
Dec 17, 2024
Merged

[#79] New architcture with tokens wrapper #352

merged 36 commits into from
Dec 17, 2024

Conversation

pylapp
Copy link
Member

@pylapp pylapp commented Dec 13, 2024 •
edited
Loading

Related issues

Closing #79

Description

Motivation & Context

Need to have tokens wrapped in dedicated objects to keep OUDSTheme light, improve tests, improve doc, enchance developer experience

Types of change

  • Breaking change (fix or feature that would change existing functionality)

Previews

Checklist

Contribution

Accessibility

  • (NA) My change follows accessibility good practices

Design

  • (NA) My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I checked my changes do not add new SwiftLint warnings
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • (NA) Design review has been done
  • (NA) Accessibiltiy review has been done
  • (NA) Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues
  • The wiki has been updated if needed (optional)

@pylapp
chore: update CHANGELOG (#79)
0145ba7 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp pylapp requested a review from ludovic35 as a code owner December 13, 2024 08:28
@pylapp pylapp linked an issue Dec 13, 2024 that may be closed by this pull request
[Refactoring] Refactoring of theme with wrappers, update documentations #79
Closed
27 tasks
@pylapp pylapp marked this pull request as draft December 13, 2024 08:28
@pylapp pylapp force-pushed the 79-refactoring-refactoring-of-theme-with-wrappers branch from bbec5ab to 3223f10 Compare December 13, 2024 10:58
@pylapp pylapp force-pushed the 79-refactoring-refactoring-of-theme-with-wrappers branch from a65c00c to 9d4df70 Compare December 13, 2024 13:50
@pylapp pylapp force-pushed the 79-refactoring-refactoring-of-theme-with-wrappers branch from 91fb437 to 5312e81 Compare December 13, 2024 16:47
@pylapp pylapp force-pushed the 79-refactoring-refactoring-of-theme-with-wrappers branch from d561d55 to 6f95eff Compare December 16, 2024 13:31
@pylapp
docs: update documentation for component tokens (#79)
b3d15cf 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
docs: update documentation for foundation catalog (#79)
587eeca 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
docs: update documentation for Orange theme catalog (#79)
12cf3f6 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
docs: more doc (#79)
372428c 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
docs: update documentation for components ccatalog (#79)
4051929 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
docs: update SP README (#79)
ef181da 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
docs: more doc on components module (#79)
71bdd3a 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
docs: improve README of SP (#79)
1277fc2 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
doc:s update doc (#79)
3e24e16 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp pylapp marked this pull request as ready for review December 16, 2024 16:41
pylapp added 13 commits December 17, 2024 11:47
@pylapp
chore(review): remove whitespaces
b72cc9e 
Resolve #352 (comment)
Resolve #352 (comment)
Resolve #352 (comment)

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
refactor(review): rename wrapper to provider for tokens of borders (#79)
6309b9b 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
refactor(review): rename wrapper to provider for tokens of colors (#79)
3dbe772 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
refactor(review): rename wrapper to provider for tokens of elevations (…
7798b5d 
…#79)

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
refactor(review): rename wrapper to provider for tokens of fonts (#79)
899ebf1 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
refactor(review): rename wrapper to provider for tokens of grids (#79)
c854d33 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
refactor(review): rename wrapper to provider for tokens of opacities (#…
c2ece11 
…79)

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
refactor(review): rename wrapper to provider for tokens of sizes (#79)
1ba6494 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
refactor(review): rename wrapper to provider for tokens of spaces (#79)
2e6917e 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
refactor(review): more rename from wrappers to providers (#79)
27b3410 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
refactor(review): more rename from wrappers to providers (#79)
cab6821 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
refactor(review): more rename from wrappers to providers (#79)
dee4293 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
refactor(review): more rename from wrappers to providers (#79)
e8a04e6 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp pylapp merged commit 6b5a3e0 into develop Dec 17, 2024
7 of 8 checks passed
@pylapp pylapp deleted the 79-refactoring-refactoring-of-theme-with-wrappers branch December 17, 2024 11:45
pylapp added a commit that referenced this pull request Dec 18, 2024
@pylapp
refactor: apply new architecture with tokens providers (#79) (#352)
7399c33 
- Defines tokens providers embeded in the theme
- Improve documentation (DocC catalogs, Swift doc)

Reviewed-by: Ludovic Pinel <[email protected]>
Acked-by: Ludovic Pinel <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludovic35 ludovic35 ludovic35 requested changes

Assignees

@ludovic35 ludovic35

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Refactoring] Refactoring of theme with wrappers, update documentations
2 participants
@pylapp @ludovic35