-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#157] On opacity screen, add a border around the view showing the opacity #162
[#157] On opacity screen, add a border around the view showing the opacity #162
Conversation
@ludovic35 Si ta PR est prête à être relue, retire l'état "draft". J'ai été notifié que tu voulais une revue, donc je m'attends naturellement à ce que la PR ne soit pas en draft. Il faut aussi que tu synchronises (via rebase) ta branche avec develop qui a bougé depuis. D'ailleurs tu n'as coché aucune case de ta PR ; or il y a une bonne partie que tu peux remplir ou remplacer par NA comme indiqué dans le template. On ne peut pas se permettre de devoir remettre d'équerre les PR de chacun ;) |
This comment was marked as spam.
This comment was marked as spam.
8a7c935
to
9e8b469
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
OUDS/Core/Components/Sources/ViewModifiers/BorderModifiers/BorderModifier.swift
Outdated
Show resolved
Hide resolved
This comment was marked as spam.
This comment was marked as spam.
ad9f51a
to
d8e74d3
Compare
d8e74d3
to
3259ceb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Note: Please transform
- [ ]
into- (NA)
in the description when things are not applicableRelated issues
#157
Description
Motivation & Context
Types of change
Previews
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)