Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#157] On opacity screen, add a border around the view showing the opacity #162

Conversation

ludovic35
Copy link
Member

@ludovic35 ludovic35 commented Oct 4, 2024

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

#157

Description

Motivation & Context

Types of change

  • Refactoring (non-breaking change)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • (NA) I have added unit tests to cover my changes (optional)

Documentation

  • (NA) My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • (NA) Design review has been done
  • (NA) Accessibiltiy review has been done
  • (NA) Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues

pylapp

This comment was marked as outdated.

CHANGELOG.md Outdated Show resolved Hide resolved
@pylapp
Copy link
Member

pylapp commented Oct 4, 2024

@ludovic35 Si ta PR est prête à être relue, retire l'état "draft". J'ai été notifié que tu voulais une revue, donc je m'attends naturellement à ce que la PR ne soit pas en draft.

Il faut aussi que tu synchronises (via rebase) ta branche avec develop qui a bougé depuis.

D'ailleurs tu n'as coché aucune case de ta PR ; or il y a une bonne partie que tu peux remplir ou remplacer par NA comme indiqué dans le template. On ne peut pas se permettre de devoir remettre d'équerre les PR de chacun ;)

@ludovic35

This comment was marked as spam.

@ludovic35 ludovic35 force-pushed the 157-demo-app-on-opacity-screen-add-a-border-around-the-view-showing-the-opacity branch from 8a7c935 to 9e8b469 Compare October 7, 2024 07:27
Copy link
Member Author

@ludovic35 ludovic35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@ludovic35 ludovic35 marked this pull request as ready for review October 7, 2024 07:35
CHANGELOG.md Outdated Show resolved Hide resolved
@ludovic35

This comment was marked as spam.

@ludovic35 ludovic35 force-pushed the 157-demo-app-on-opacity-screen-add-a-border-around-the-view-showing-the-opacity branch from ad9f51a to d8e74d3 Compare October 7, 2024 12:22
@ludovic35 ludovic35 force-pushed the 157-demo-app-on-opacity-screen-add-a-border-around-the-view-showing-the-opacity branch from d8e74d3 to 3259ceb Compare October 7, 2024 12:23
Copy link
Member

@pylapp pylapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pylapp pylapp merged commit 8dcd914 into develop Oct 7, 2024
3 of 4 checks passed
@pylapp pylapp deleted the 157-demo-app-on-opacity-screen-add-a-border-around-the-view-showing-the-opacity branch October 7, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Demo App] On opacity screen, add a border around the view showing the opacity
2 participants