[#139] Remove web-specific grid raw tokens and non-max-min-width grid semantic tokens #147

Tayebsed93 · 2024-10-02T10:47:33Z

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

#139

Description

Remove useless tokens

Motivation & Context

Keep the stack updated and aligned with Figma

Types of change

Breaking change (fix or feature that would change existing functionality)

Previews

Checklist

Contribution

I have read the contributing guidelines

Accessibility

(NA) My change follows accessibility good practices

Design

(NA) My change respects the design guidelines of Orange Unified Design System

Development

My change follows the developer guide
I have added unit tests to cover my changes (optional)

Documentation

My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

The evolution have been tested and the project builds for iPhones and iPads
Code review has been done by reviewers according to CODEOWNERS file
(NA) Design review has been done
(NA) Accessibiltiy review has been done
(NA) Q/A team has tested the evolution
Documentation has been updated if relevant
Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
CHANGELOG has been updated respecting keep a changelog rules and reference the issues

pylapp

Pour iOS nous n'utilisons pas les tokens medium ; il faut que tu les retires et que tu conserves les tokens regular que tu as enlevés (min et max).

CHANGELOG.md

OUDS/Core/OUDS/Sources/OUDSTheme/OUDSTheme+SemanticTokens/OUDSTheme+GridSemanticTokens.swift

pylapp · 2024-10-02T12:20:54Z

OUDS/Core/OUDS/Sources/OUDSTheme/OUDSTheme+SemanticTokens/OUDSTheme+GridSemanticTokens.swift

+
+    // MARK: Semantic token - Grid - iOS Medium
+
+    @objc open var gridMediumMinWidth: GridMediumSemanticToken { GridRawTokens.gridMinWidthMedium }


Pour iOS il n'y a pas de tokens gridMediumMinWidth et gridMediumMaxWidth

OUDS/Core/OUDS/Tests/OUDSTheme/MockTheme/MockTheme+GridSemanticTokens.swift

OUDS/Core/Tokens/RawTokens/Sources/Values/GridRawTokens+Values.swift

OUDS/Core/Tokens/RawTokens/Tests/GridRawTokensTests.swift

OUDS/Core/Tokens/SemanticTokens/Sources/TypeAliases/GridSemanticTokens+Aliases.swift

OUDS/Core/Tokens/SemanticTokens/Sources/Values/GridSemanticTokens.swift

pylapp

LGTM, congrats @Tayebsed93!

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>

Release of version 0.3.0 See below the full CHANGELOG details. Added - [Library] Add color semantic tokens `colorBackgroundStatusNeutral`, some `OnBackgroundEmphasized`, `colorBackgroundAction`, `colorBackgroundAlways`, `colorContent` variants - [Library] Add typography semantic tokens for font letter spacing - [DemoApp] Create token section (Border, Typography, Elevation, Opacity) ([#120](#120)) - [Library] Unit tests for multiple tokens - [Library] Add color semantic composite tokens embeding light and dark modes values - [Library] Add spacing semantic tokens "huge" and "jumbo" - [Library] Add closed "sys" dimension semantic tokens - [Tool] GitHub issue template for tokens update request - [Library] Add more sizing semantic tokens ([#122](#122)) - [Library] Add letter spacing and more font family tokens for typography ([#51](#51)) Changed - [Library] Rename and move color raw tokens for core, Orange brand and Sosh brand - [Library] Remove web-specific grid tokens, keep compact/regular widths ([#147](#147)) - [Library] Rename of typography font weight raw tokens - [Library] Rename dimension semantic tokens to apply T-Shirt size rules ([#130](#130)) - [Library] Rename `SizingCompositeSemanticToken` to `MultipleSizingSemanticToken` to keep "composite" word for *Figma* design system - [Library] Rename `ColorCompositeSemanticToken` to `MultipleColorRawToken` to keep "composite" word for *Figma* design system - [Library] Rename `TypographyCompositeSemanticToken` to `MultipleTypographyTokens` to keep "composite" word for *Figma* design system - [Library] Rename `SpacingCompositeSemanticToken` to `MultipleSpacingTokens` to keep "composite" word for *Figma* design system - [Library] Rename `SizingCompositeSemanticToken` to `MultipleSizingTokens` to keep "composite" word for *Figma* design system - [Library] Rename `ColorCompositeSemanticToken` to `MultipleColorTokens` to keep "composite" word for *Figma* design system - [Library] Elevation colors have been merged into "multiple" objects colors to have less variables and manage color schemes - [Library] Rename `ColorCompositeSemanticToken` to `MultipleColorSemanticToken` to keep "composite" word for *Figma* design system - [Library] Elevation colors have been merged into composite colors to have less variables and manage color schemes - [Library] Rename `SpacingCompositeSemanticToken` to `MultipleSpacingTokens` to keep "composite" word for *Figma* design system - [Library] Rename `SizingCompositeSemanticToken` to `MultipleSizingTokens` to keep "composite" word for *Figma* design system - [Library] Rename `ColorCompositeSemanticToken` to `MultipleColorTokens` to keep "composite" word for *Figma* design system - [Library] Elevation colors have been merged into "multiple" objects colors to have less variables and manage color schemes - [Library] Update color semantic tokens to better manage light and dark modes values - [Library] Update elevation colors focus light and dark - [Library] Rename space padding inline component tokens by removing "component" word - [Library] Improve documentation about raw and semantic tokens definitions ([#127](#127)) - [Library] Improve documentation about raw tokens definitions - [Library] Move composite tokens elsewhere to help parser ([#129](#129)) - [Library] Improve documentation about raw and semantic tokens definitions ([#127](#127)) - [Library] Rename some sizing semantic tokens ([#122](#122)) - [Library] Replace "adaptable" word by "scaled" in space semantic tokens, "fix" by "fixed" and remove "layout" ([#117](#117)) Removed - [Library] Color semantic token `colorBackgroundEmphasizedSecondary`, `colorOnBackground` variants - [Library] Remove raw tokens `elevationZIndex` ([#119](#119)) Fixed - [Library] Blur values for elevation composite raw tokens Co-authored-by: Pierre-Yves Lapersonne <[email protected]> Co-authored-by: Ludovic Pinel <[email protected]> Co-authored-by: Tayeb Sedraia <[email protected]> Signed-off-by: Pierre-Yves Lapersonne <[email protected]>

pylapp · 2024-10-04T22:21:42Z

New version available since version v0.3.0 (see this thread)

Tayebsed93 requested review from pylapp and ludovic35 as code owners October 2, 2024 10:47

Tayebsed93 linked an issue Oct 2, 2024 that may be closed by this pull request

[Tokens] Drop some grid{Min|Maw|}Width* raw tokens #139

Closed

pylapp assigned Tayebsed93 Oct 2, 2024

Tayebsed93 force-pushed the 139-drop-some-gridmin|maw|width-raw-tokens branch from d1ba40c to c9af803 Compare October 2, 2024 11:26

pylapp requested changes Oct 2, 2024

View reviewed changes

pylapp changed the title ~~Remove web-specific grid tokens, keep compact/regular widths~~ [#139] Remove web-specific grid raw tokens and non-max-min-width grid semantic tokens Oct 2, 2024

pylapp previously approved these changes Oct 2, 2024

View reviewed changes

Tayebsed93 added 10 commits October 2, 2024 15:55

Remove web-specific grid tokens, keep compact/regular widths

b67a60b

Add medium token

7789c59

doc : add changelog

b8f2e4b

review : keep grid min max width regular tokens

391f215

review : keep gridRegularMin/MaxWidth in mocktheme

e8ae782

review : revert test to regular tokens

86d7e6c

review : update token values, keep regular

6b81a0f

review : remove unused medium typealias

b4acd0a

review : keep regular tokens; remove medium tokens

5a43642

review : changelog

a0ab9cb

pylapp dismissed their stale review via a0ab9cb October 2, 2024 13:55

pylapp force-pushed the 139-drop-some-gridmin|maw|width-raw-tokens branch from c1617b0 to a0ab9cb Compare October 2, 2024 13:55

pylapp previously approved these changes Oct 2, 2024

View reviewed changes

chore: clean up after rebase

3832b49

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>

pylapp dismissed their stale review via 3832b49 October 2, 2024 14:04

pylapp merged commit 8707970 into develop Oct 2, 2024
3 of 4 checks passed

pylapp deleted the 139-drop-some-gridmin|maw|width-raw-tokens branch October 2, 2024 14:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#139] Remove web-specific grid raw tokens and non-max-min-width grid semantic tokens #147

[#139] Remove web-specific grid raw tokens and non-max-min-width grid semantic tokens #147

Tayebsed93 commented Oct 2, 2024 •

edited by pylapp

Loading

pylapp left a comment

pylapp Oct 2, 2024

pylapp left a comment

pylapp commented Oct 4, 2024


		// MARK: Semantic token - Grid - iOS Medium

		@objc open var gridMediumMinWidth: GridMediumSemanticToken { GridRawTokens.gridMinWidthMedium }

[#139] Remove web-specific grid raw tokens and non-max-min-width grid semantic tokens #147

[#139] Remove web-specific grid raw tokens and non-max-min-width grid semantic tokens #147

Conversation

Tayebsed93 commented Oct 2, 2024 • edited by pylapp Loading

Related issues

Description

Motivation & Context

Types of change

Previews

Checklist

Contribution

Accessibility

Design

Development

Documentation

Checklist (for Core Team only)

pylapp left a comment

Choose a reason for hiding this comment

pylapp Oct 2, 2024

Choose a reason for hiding this comment

pylapp left a comment

Choose a reason for hiding this comment

pylapp commented Oct 4, 2024

Tayebsed93 commented Oct 2, 2024 •

edited by pylapp

Loading