Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emacs mode #1105

Closed
wants to merge 1 commit into from
Closed

Add emacs mode #1105

wants to merge 1 commit into from

Conversation

azzamsa
Copy link
Contributor

@azzamsa azzamsa commented Dec 16, 2022

No description provided.

contrib/emacs/hurl-mode.el Outdated Show resolved Hide resolved
contrib/emacs/hurl-mode.el Outdated Show resolved Hide resolved
@azzamsa azzamsa mentioned this pull request Dec 16, 2022
contrib/emacs/hurl-mode.el Outdated Show resolved Hide resolved
@jcamiel
Copy link
Collaborator

jcamiel commented Dec 16, 2022

Just another thing, our CONTRIBUTING.md require to be signed and marked as "Verified" (signed with a GPG, SSH, or S/MIME that is successfully verified by GitHub). You can see check how to do this here https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification. I can assist you if you need!

contrib/emacs/hurl-mode.el Outdated Show resolved Hide resolved
@jcamiel
Copy link
Collaborator

jcamiel commented Dec 16, 2022

/accept

@hurl-bot
Copy link
Collaborator

🕗 /accept is running, please wait for completion.

@hurl-bot
Copy link
Collaborator

❌ You have to rebase your azzamsa/hurl/master branch first because there are new commits pending on target Orange-OpenSource/hurl/master branch:

  • 0fc18e9 Fix Clippy warnings 1.66.0
  • d1767e1 Clean ci docker jobs
  • 77f7909 Add debug sh functions
  • 6f0e666 Fix false negatives on dockerised tests
  • a31c03d Add shell checks on shebang and error handling
  • 662ec81 Standardised shell scripts shebang and error handling

@jcamiel
Copy link
Collaborator

jcamiel commented Dec 16, 2022

@azzamsa Could you please rebase your PR to appease our CI ? I've try to update your fork but I didn't have the right to push on it, thanks!

@azzamsa
Copy link
Contributor Author

azzamsa commented Dec 16, 2022

@jcamiel done.

@azzamsa
Copy link
Contributor Author

azzamsa commented Dec 16, 2022

@jcamiel one test is failed. Is there anything I can do about it?

Looks like outdated dependencies.

@jcamiel
Copy link
Collaborator

jcamiel commented Dec 16, 2022

@azzamsa I will to the updates. In the meantime would you be possible to put your PR on a branch (rather on master)? I think this is why I can't edit your fork (unless you've activated the option to not allow 'edit by maintainers'). This way, as your PR is OK, I can manage everything instead of asking you to rebase your work (currently I can't edit your fork, I don't know why). We can try this!
I can force accept your PR, let's try this

@jcamiel
Copy link
Collaborator

jcamiel commented Dec 16, 2022

/accept --force

@azzamsa azzamsa mentioned this pull request Dec 16, 2022
@azzamsa azzamsa closed this Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants