This repository has been archived by the owner on Oct 20, 2022. It is now read-only.
add statefulset recovery action #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| logrus.WithFields(logrus.Fields{"cluster": cc.Name, "rack": dcRackName}).Info("Statefulset is Ready") | ||
| lastAction.Status = api.StatusDone | ||
| lastAction.EndTime = &now | ||
| labels := map[string]string{"operation-name": api.OperationCleanup} |
There was a problem hiding this comment.
I don't understand why there is a cleanup operation in that case.
| @@ -182,6 +187,20 @@ func UpdateStatusIfUpdateResources(cc *api.CassandraCluster, dcRackName string, | |||
| } | |||
| */ | |||
|
|
|||
| //UpdateStatusIfStatefulSetStatusHasChanged updates CassandraCluster Action Status if any pod is not Ready | |||
| func UpdateStatusIfStatefulSetStatusHasChanged(cc *api.CassandraCluster, dcRackName string, storedStatefulSet *appsv1.StatefulSet, status *api.CassandraClusterStatus) bool { | |||
There was a problem hiding this comment.
This one looks dangerous to me. It can happen during the creation of the cluster, whenever there is an operation at the stfs level etc..
@allamand don't hesitate to weigh in.
There was a problem hiding this comment.
yes, I didn't take into account the creation of the cluster,
I will close it.
|
I think there is a misunderstanding of what the operator does and the way it checks different status changes or if there are pending operation. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the reason for #96 is that after deleting the pod, the
lastClusterActionhas not been updated, andlastClusterActionStatusis always Done, so thestatus.Phasecan not be updatedhttps://github.com/Orange-OpenSource/cassandra-k8s-operator/blob/73fd24e4d80d853a640defa42b91345cb29847ba/pkg/controller/cassandracluster/reconcile.go#L527