This repository has been archived by the owner on Oct 20, 2022. It is now read-only.
Fix issue #374 with determining the cassandra version from image #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a unit test to ensure it works as expected in 2/3 different cases. |
Done, pls review |
cscetbon
reviewed
Nov 1, 2021
|
I got some permissions issues to trigger all our tests and have to wait to get someone on it and fix it. |
|
Hello @ibumarskov , |
fdehay
approved these changes
Nov 10, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Fix cassandra version definition in case we have custom port for image repository.