Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting MacOS hotkeys #67

Closed
AndreevAndrei opened this issue Dec 17, 2019 · 8 comments · Fixed by #393
Closed

Supporting MacOS hotkeys #67

AndreevAndrei opened this issue Dec 17, 2019 · 8 comments · Fixed by #393
Labels
platform-specific Related to specific platforms

Comments

@AndreevAndrei
Copy link
Contributor

It's not very comfortable to use Ctrl+* to shortcut in MacOS. It would be better if Pixelorama will support Cmd+*
I'de like to fix it in this week

@Calinou
Copy link
Contributor

Calinou commented Dec 17, 2019

I think it should be as easy as replacing all instances of KEY_MASK_CTRL with KEY_MASK_CMD in scripts 🙂

That said, the Copy and Paste shortcuts are defined in the project's input map. These are set to Control+C and Control+V respectively; I'm not sure how you could reassign them to Command+C and Command+V (especially if you're not on macOS like me). Maybe you could conditionally bind them to Meta+C and Meta+V on macOS using if OS.has_feature("OSX"): in a script.

@AndreevAndrei
Copy link
Contributor Author

yeap, it's realy easy, just a few fixes
now it's comfortable to use on macOS)

OverloadedOrama added a commit that referenced this issue Dec 17, 2019
[hotkeys] Add cmd-key supporting for macOS, closes #67
@OverloadedOrama
Copy link
Member

The issue shouldn't be closed yet because, like Calinou said, Control+C and Control+V are still being used for copy&pasting, and since I'm on a Windows machine, I don't know if I can re-assign them to use Command instead.

@OverloadedOrama
Copy link
Member

OverloadedOrama commented Dec 17, 2019

Taking a look inside project.godot, it seems that both "control" and "command" are true on copy and paste. Can you check and see if they're working?

@AndreevAndrei
Copy link
Contributor Author

AndreevAndrei commented Dec 18, 2019

at current settings I need to hold control + command + c to copy
If I set command + c in project.godot it works fine

@gingerbeardman
Copy link

gingerbeardman commented Nov 23, 2020

I'm sure we all are aware, but I wanted to mention this is still an issue on macOS with 0.8.1 for any people new to this thread

@Schweini07
Copy link
Contributor

Schweini07 commented Dec 4, 2020

I think the fix for this is to add to seperate key actions in the input menu.
Like this:
save_key

  • ctrl + s
  • command + s

I tried it on a mac and it seems to work, I'll look at it tomorrow and probably open a PR.

@Schweini07
Copy link
Contributor

Schweini07 commented Dec 4, 2020

Sadly a false alarm.
It seems the order in which those actions are listed are important.
I had it like that:
save_key

  • command + s
  • ctrl +s

In this case ctrl+sdoesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform-specific Related to specific platforms
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants