Skip to content

Commit

Permalink
backport #920 (#921)
Browse files Browse the repository at this point in the history
  • Loading branch information
Variable-ind authored Oct 14, 2023
1 parent 7416ed3 commit 9ae93a1
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 11 deletions.
14 changes: 8 additions & 6 deletions src/Autoload/OpenSave.gd
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ func save_pxo_file(
autosave: bool,
use_zstd_compression := true,
project: Project = Global.current_project
) -> void:
) -> bool:
if !autosave:
project.name = path.get_file()
var serialized_data := project.serialize()
Expand All @@ -224,15 +224,15 @@ func save_pxo_file(
)
Global.error_dialog.popup_centered()
Global.dialog_open(true)
return
return false
var to_save := JSON.print(serialized_data)
if !to_save:
Global.error_dialog.set_text(
tr("File failed to save. Converting dictionary to JSON failed.")
)
Global.error_dialog.popup_centered()
Global.dialog_open(true)
return
return false

# Check if a file with the same name exists. If it does, rename the new file temporarily.
# Needed in case of a crash, so that the old file won't be replaced with an empty one.
Expand All @@ -250,14 +250,15 @@ func save_pxo_file(

if err != OK:
if temp_path.is_valid_filename():
return
return false
Global.error_dialog.set_text(
tr("File failed to save. Error code %s") % str(err, ErrorManager.parse(err, " (", ")"))
)
Global.error_dialog.popup_centered()
Global.dialog_open(true)
file.close()
return
if file: # Failsafe
file.close()
return false

if !autosave:
current_save_paths[Global.current_project_index] = path
Expand Down Expand Up @@ -308,6 +309,7 @@ func save_pxo_file(
)

save_project_to_recent_list(path)
return true


func open_image_as_new_tab(path: String, image: Image) -> void:
Expand Down
11 changes: 6 additions & 5 deletions src/Main.gd
Original file line number Diff line number Diff line change
Expand Up @@ -287,12 +287,13 @@ func _on_SaveSprite_file_selected(path: String) -> void:

func save_project(path: String) -> void:
var zstd: bool = Global.save_sprites_dialog.get_vbox().get_node("ZSTDCompression").pressed
OpenSave.save_pxo_file(path, false, zstd)
Global.open_sprites_dialog.current_dir = path.get_base_dir()
Global.config_cache.set_value("data", "current_dir", path.get_base_dir())
var success = OpenSave.save_pxo_file(path, false, zstd)
if success:
Global.open_sprites_dialog.current_dir = path.get_base_dir()
Global.config_cache.set_value("data", "current_dir", path.get_base_dir())

if is_quitting_on_save:
_quit()
if is_quitting_on_save:
_quit()


func _on_SaveSpriteHTML5_confirmed() -> void:
Expand Down

0 comments on commit 9ae93a1

Please sign in to comment.