(#75) Don't register trigger on non-Postgres databases #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The trigger in migration 0004 is registered regardless of database backend currently. This adds a check to make sure we are connected to a postgres database before running it. Type: bug
|
Thanks for this catch. I will write a small test for it before doing the release. Will report back when this is released |
|
Thank you so much! |
|
Released in 3.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into trouble with our tests, which use an in-memory SQLite database. The solution proposed in #75 fixes this and there doesn't seem to be any issues otherwise. Looks like a PR for it just hasn't been made yet but this should do it.