Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hostname and idn-hostname format validators #82

Merged
merged 35 commits into from
Apr 15, 2024
Merged

Conversation

OptimumCode
Copy link
Owner

Related to #54

@OptimumCode OptimumCode added the enhancement New feature or request label Mar 12, 2024
@OptimumCode OptimumCode marked this pull request as draft March 12, 2024 17:32
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 82.67898% with 75 lines in your changes are missing coverage. Please review.

Project coverage is 90.10%. Comparing base (8900520) to head (0549f41).

Files Patch % Lines
...ema/internal/formats/IdnHostnameFormatValidator.kt 76.44% 7 Missing and 42 partials ⚠️
...imumcode/json/schema/internal/hostname/Punycode.kt 87.19% 5 Missing and 16 partials ⚠️
...timumcode/json/schema/internal/util/UnicodeUtil.kt 81.48% 0 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
- Coverage   91.43%   90.10%   -1.33%     
==========================================
  Files         104      108       +4     
  Lines        2358     2779     +421     
  Branches      604      778     +174     
==========================================
+ Hits         2156     2504     +348     
- Misses         36       48      +12     
- Partials      166      227      +61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OptimumCode OptimumCode force-pushed the hostname-format branch 2 times, most recently from ceb8850 to 4579468 Compare March 22, 2024 14:34
@OptimumCode OptimumCode marked this pull request as ready for review April 13, 2024 17:16
@OptimumCode OptimumCode enabled auto-merge (squash) April 15, 2024 17:31
@OptimumCode OptimumCode merged commit 6c2baf5 into main Apr 15, 2024
9 checks passed
@OptimumCode OptimumCode deleted the hostname-format branch April 17, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant