Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add partial support for format keyword #72

Merged
merged 15 commits into from
Feb 29, 2024
Merged

Add partial support for format keyword #72

merged 15 commits into from
Feb 29, 2024

Conversation

OptimumCode
Copy link
Owner

This patch introduces:

  • API for implementing user's format validator and registering it in the schema
  • Support for data/time formats

Related to #54

@OptimumCode OptimumCode added the enhancement New feature or request label Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 94.88636% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 91.03%. Comparing base (b1bd666) to head (1356caf).

Files Patch % Lines
...son/schema/internal/formats/TimeFormatValidator.kt 70.00% 0 Missing and 6 partials ⚠️
...n/io/github/optimumcode/json/schema/Annotations.kt 0.00% 1 Missing ⚠️
...schema/internal/config/Draft7SchemaLoaderConfig.kt 75.00% 0 Missing and 1 partial ⚠️
...ternal/factories/general/FormatAssertionFactory.kt 97.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
+ Coverage   90.53%   91.03%   +0.49%     
==========================================
  Files          90       99       +9     
  Lines        2093     2252     +159     
  Branches      521      561      +40     
==========================================
+ Hits         1895     2050     +155     
+ Misses         40       36       -4     
- Partials      158      166       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OptimumCode OptimumCode merged commit 4f7cdbf into main Feb 29, 2024
8 checks passed
@OptimumCode OptimumCode deleted the issue_#54 branch February 29, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant