Skip to content

Add support for draft 4 #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Add support for draft 4 #140

merged 2 commits into from
Jun 19, 2024

Conversation

OptimumCode
Copy link
Owner

Resolves #139

@OptimumCode OptimumCode added the enhancement New feature or request label Jun 19, 2024
@OptimumCode OptimumCode enabled auto-merge (squash) June 19, 2024 07:19
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 15 lines in your changes missing coverage. Please review.

Project coverage is 90.59%. Comparing base (68756be) to head (5b32acc).

Files Patch % Lines
.../factories/number/Draft4MaximumAssertionFactory.kt 66.66% 0 Missing and 7 partials ⚠️
.../factories/number/Draft4MinimumAssertionFactory.kt 66.66% 0 Missing and 7 partials ⚠️
...schema/internal/config/Draft4SchemaLoaderConfig.kt 97.91% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
- Coverage   90.75%   90.59%   -0.17%     
==========================================
  Files         126      130       +4     
  Lines        3743     3847     +104     
  Branches     1027     1055      +28     
==========================================
+ Hits         3397     3485      +88     
- Misses         65       66       +1     
- Partials      281      296      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OptimumCode OptimumCode merged commit d2d2f03 into main Jun 19, 2024
10 checks passed
OptimumCode added a commit that referenced this pull request Jun 19, 2024
Resolves #139

(cherry picked from commit d2d2f03)
@OptimumCode OptimumCode deleted the issue_#139 branch June 19, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: support for draft 4
1 participant