Re-add the ability to get major edge lines. #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bump version from 14.0.0 (current release) to 14.1.0, because we're adding a method. * Added back `get_major_edge_line_indices`, which was removed by commit 9ff8564. However, it is (still) buggy (it misses the first and last index), so it is marked deprecated. This is just so that this can go into a release which is a minor rather than major version bump. * Added replacement `get_major_edges_line_indices` which returns the correct lines. However, it returns *all* relevant edges, rather than allowing selection of a single edge. * Removed unused `use std::sync::Arc;`.
6 tasks
|
Howdy -- this looks good to me. I'll try to make sure to remove the deprecated function next time I'm pushing a major revision. I'll get this merged in. |
jleibs
pushed a commit
to rerun-io/rerun
that referenced
this pull request
Jul 30, 2024
…#7014) ### What Instead of an icosahedron, use an octahedron. The edges of the octahedron become axis-aligned great circles around the subdivided mesh, which makes more sense for ellipsoid visualization since the axes and their perpendicular planes are significant.  This will make it easy to also choose to draw *only* the axis-aligned great circles (once OptimisticPeach/hexasphere#26 is available), making this a step towards implementing #6962. ### Checklist * [X] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [X] I've included a screenshot or gif (if applicable) * [ ] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7014?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7014?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [X] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [X] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [X] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/7014) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_major_edge_line_indices, which was removed by commit 9ff8564. However, it is (still) buggy (it misses the first and last index), so it is marked deprecated. This is just so that this can go into a release which is a minor rather than major version bump.get_major_edges_line_indiceswhich returns the correct lines. However, it returns all relevant edges, rather than allowing selection of a single edge.use std::sync::Arc;.