Fix OppijaServiceImpl use of incorrect YLEISTUNNISTE_LUONTI access right constant #371
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
OppijaServiceImpl
methods use thepermissionChecker.getAllOrganisaatioOids(...)
andpermissionChecker.getOrganisaatioOidsByKayttaja(...)
methods with inconsistentYLEISTUNNISTE_LUONTI_ACCESS_RIGHT_LITERAL
andYLEISTUNNISTE_LUONTI_ACCESS_RIGHT
constants as arguments. TheYLEISTUNNISTE_LUONTI_ACCESS_RIGHT
constant includes the fullAPP_OPPIJANUMEROREKISTERI_*
prefix, which leads to thepermissionChecker
checking for anAPP_OPPIJANUMEROREKISTERI_APP_OPPIJANUMEROREKISTERI_YLEISTUNNISTE_LUONTI
role instead ofAPP_OPPIJANUMEROREKISTERI_YLEISTUNNISTE_LUONTI
.