Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OppijaServiceImpl use of incorrect YLEISTUNNISTE_LUONTI access right constant #371

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SpComb
Copy link

@SpComb SpComb commented Oct 16, 2024

The OppijaServiceImpl methods use the permissionChecker.getAllOrganisaatioOids(...) and permissionChecker.getOrganisaatioOidsByKayttaja(...) methods with inconsistent YLEISTUNNISTE_LUONTI_ACCESS_RIGHT_LITERAL and YLEISTUNNISTE_LUONTI_ACCESS_RIGHT constants as arguments. The YLEISTUNNISTE_LUONTI_ACCESS_RIGHT constant includes the full APP_OPPIJANUMEROREKISTERI_* prefix, which leads to the permissionChecker checking for an APP_OPPIJANUMEROREKISTERI_APP_OPPIJANUMEROREKISTERI_YLEISTUNNISTE_LUONTI role instead of APP_OPPIJANUMEROREKISTERI_YLEISTUNNISTE_LUONTI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant