This repository has been archived by the owner on Dec 3, 2019. It is now read-only.
Https code school url validation #509
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wever, locations_controller_test is broke now, suspect need to validate mock data
kylemh
reviewed
May 4, 2019
| as: :json | ||
|
|
||
| errors = JSON.parse(response.body)['errors'] | ||
| assert errors.include? 'Url must be HTTPS, if unable please secure your site' |
There was a problem hiding this comment.
If you have to have HTTPS for a .dev domain (https://get.dev/#benefits), any coding school worth their salt should have it by default. Would be interested to hear use cases where it's HTTP, but I can't think of a reason to not have it nowadays.
kylemh
approved these changes
May 4, 2019
|
Whoops. Didn't mean to close the un-merged PR... 😕 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Small change to the Makefile with comments that can help anyone debugging to output verbose tests or test just one when running
make testUpdated the
code_school.rbmodel to have URL validation for HTTPS. Uses Regex to accomplish this.Added a test to ensure that it will throw an error when a HTTP address is given.
Updated the Code School Factory Faker for URL to generate HTTPS urls for mock data in testing
Issue Resolved
Fixes #436