feat(step-generation): create fn to get custom liquid class properties#18558
Merged
jerader merged 5 commits intochore_release-pd-8.5.0from Jun 9, 2025
Merged
feat(step-generation): create fn to get custom liquid class properties#18558jerader merged 5 commits intochore_release-pd-8.5.0from
jerader merged 5 commits intochore_release-pd-8.5.0from
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## chore_release-pd-8.5.0 #18558 +/- ##
===========================================================
+ Coverage 25.98% 56.98% +31.00%
===========================================================
Files 3258 3274 +16
Lines 280648 281846 +1198
Branches 27621 33747 +6126
===========================================================
+ Hits 72923 160620 +87697
+ Misses 207698 121032 -86666
- Partials 27 194 +167
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ddcc4
approved these changes
Jun 6, 2025
| z_offset?: number | ||
| mm_from_edge?: number | ||
| speed?: number | ||
| } |
Contributor
There was a problem hiding this comment.
Hm, do these overlap at all with an existing schema? I'd prefer not to write another file with the same fields if we can help it.
Collaborator
Author
There was a problem hiding this comment.
good call, i'll take a look!
Contributor
There was a problem hiding this comment.
I suspect the answer is that there is an existing schema we could use, but we'd have to generate the schema file from either Sanniti's Python TypedDict, or from shared-data/liquid-class/schemas/1.json. (But still, generating the schema programmatically might be more reliable than typing it out by hand.)
SyntaxColoring
pushed a commit
that referenced
this pull request
Jun 10, 2025
#18558) to prep for emitting `transfer_with_liquid_class` and the other liquid class papi commands, this PR creates a helper function to get the custom liquid class properties.
ddcc4
added a commit
that referenced
this pull request
Jun 13, 2025
# Overview
The custom liquid class dict for `define_liquid_class()` is kind of big.
This PR makes the dict formatting a bit more compact: if all the entries
in the dict are scalar, and their total length is short-ish, we will
emit the dict on a single line.
Before:
```
"offset": {
"x": 1,
"y": 0,
"z": 5,
},
```
After:
```
"offset": {"x": 1, "y": 0, "z": 5},
```
(See tests for other examples.)
This PR also cleans up the code for emitting lists of pairs as Python
tuples that was introduced in PR #18558.
## Test Plan and Hands on Testing
Added/updated unit tests.
## Risk assessment
Low.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
to prep for emitting
transfer_with_liquid_classand the other liquid class papi commands, this PR creates a helper function to get the custom liquid class properties.please see Sanniti's PR here to review an example usage. Basically, this fn helps define the custom liquid class object that is used in
define_custom_liquid_class()Test Plan and Hands on Testing
Review the code and the test
Changelog
Review requests
transferArgs that don't map to anything areblowoutOffsetFromTopMm,dispenseOffsetFromBottomMm, andaspirateOffsetFromBottomMm. I'm pretty sure we can deprecate them but need to confirm.Risk assessment
low