Revert "fix(api): fix aspirate/dispense while tracking move to (#17854)" in chore_release-8.5.0#18472
Merged
Merged
Conversation
This reverts commit d06a5f3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit d06a5f3.
Overview
In PR #17854, @caila-marashaj deleted the
operation_volumeparameter from the call tomove_to_well()inaspirate_while_tracking.py, asserting that "It was previously called with theoperation_volumeparameter. This is wrong because we need z tracking to start from where the meniscus currently is, not where it's going to be."That PR was checked into
edge. I picked that PR intochore_release-8.5.0.But Caila's change somehow disappeared from
edgeentirely. The code inedgenow does have themove_to_well(operation_volume=-params.volume)parameter. @ryanthecoder thinks Caila's change was probably deleted fromedgeby one of the mergebacks fromchore_release-8.4.0intoedge.Ryan says that we do want
move_to_well(operation_volume=-params.volume). So now I have to revert Caila's change inchore_release-8.5.0.Test Plan and Hands on Testing
I'm taking Ryan's word for it that
move_to_well(operation_volume=-params.volume)is correct :)But let's run the CI tests to see if everything passes.
Risk assessment
Low I hope. Ryan says that the version with
move_to_well(operation_volume=-params.volume)is what we've tested and released, so we should use that.