Skip to content

test(api): delete protocol_api_old/test_context.py? #18412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddcc4 merged 1 commit into from
May 22, 2025
Merged

test(api): delete protocol_api_old/test_context.py? #18412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions api/src/opentrons/protocol_api/instrument_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,11 +635,7 @@ def aspirate_with_delay(
delay_with_publish(aspirate_delay)

def dispense_with_delay(push_out: Optional[float]) -> None:
# protocol_api_old/test_context.py does not allow push_out at all, even if
# it's set to None, so we have to hide the argument to make the test pass.
# I don't know if the test is even valid, but I'm afraid to change the test.
dispense_kwargs = {"push_out": push_out} if push_out is not None else {}
self.dispense(volume, None, rate, **dispense_kwargs)
self.dispense(volume, None, rate, push_out=push_out)
if dispense_delay:
delay_with_publish(dispense_delay)

Expand Down
Loading