Skip to content

feat(app): Add analytics for LPC Redesign#18383

Merged
mjhuff merged 6 commits into
edgefrom
app_add-lpc-redesign-analytics
May 19, 2025
Merged

feat(app): Add analytics for LPC Redesign#18383
mjhuff merged 6 commits into
edgefrom
app_add-lpc-redesign-analytics

Conversation

@mjhuff
Copy link
Copy Markdown
Contributor

@mjhuff mjhuff commented May 19, 2025

Closes EXEC-1490

Overview

Adds the LPC analytics outlined in the ticket/ticket convo.

This PR should target the 8.5 branch once it's cut, so we can hold off merging it until a later time.

Test Plan and Hands on Testing

Verified for the Flex:

  • Launch event occurs when expected with the correct properties
  • Apply offsets event occurs when expected with the correct properties
  • Save offsets event occurs when expected with the correct properties
  • Offset source conflict resolution event occurs when expected with the correct properties

Verified for the OT-2:

  • Launch event occurs when expected with the correct properties
  • Save offsets to run record event occurs when expected with the correct properties

Changelog

  • Added LPC analytics

Review requests

  • None in particular. This is all straightforward.

Risk assessment

  • very low

@mjhuff mjhuff requested review from a team, SyntaxColoring and sfoster1 May 19, 2025 13:11
@mjhuff mjhuff requested a review from a team as a code owner May 19, 2025 13:11
@mjhuff mjhuff added the DO NOT MERGE Indicates a PR should not be merged, even if there's a shiny green merge button available label May 19, 2025
@mjhuff mjhuff requested review from jerader and removed request for a team and jerader May 19, 2025 13:11
Copy link
Copy Markdown
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@mjhuff mjhuff removed the DO NOT MERGE Indicates a PR should not be merged, even if there's a shiny green merge button available label May 19, 2025
@mjhuff
Copy link
Copy Markdown
Contributor Author

mjhuff commented May 19, 2025

@ddcc4 This PR should be included in the app 8.5 release. Thank you!

@mjhuff mjhuff merged commit bcf5fc6 into edge May 19, 2025
40 checks passed
@mjhuff mjhuff deleted the app_add-lpc-redesign-analytics branch May 19, 2025 20:20
ddcc4 pushed a commit that referenced this pull request May 19, 2025
@ddcc4
Copy link
Copy Markdown
Contributor

ddcc4 commented May 19, 2025

@ddcc4 This PR should be included in the app 8.5 release. Thank you!

Hey @mjhuff, I'm having trouble getting this PR to cherry-pick cleanly into the candidate app 8.5.0 branch :(

App 8.5.0 is an off-cycle release that we added to support PD. App 8.5.0 is supposed to be a limited cherry-pick release off of chore_release-8.4.0, containing the features that PD 8.5 will need (namely liquid classes and Python interop).

That means anything we want to include into app 8.5.0 must cleanly cherry-pick on top of chore_release-8.4.0 (more or less), and this PR doesn't. For example, this PR uses the type Vector3D, which doesn't exist in chore_release-8.4.0.

If this really has to go into app 8.5.0, I might need your help writing a version of this PR that will cleanly cherry-pick onto chore_release-8.4.0.

@mjhuff
Copy link
Copy Markdown
Contributor Author

mjhuff commented May 20, 2025

@ddcc4 Thank you for the explanation and looking into this. Sorry for the hassle. I'd be happy to help write the necessary changes. It should be straightforward.

I'll open a new PR that targets chore_release-8.5.0 when that gets cut 👍

@ddcc4
Copy link
Copy Markdown
Contributor

ddcc4 commented May 20, 2025

I'll open a new PR that targets chore_release-8.5.0 when that gets cut 👍

Thanks! If you have time, could you write the version this PR on top of chore_release-8.4.0 now? I have a series of local branches with edited code for each of the PRs I need to cherrypick for 8.5.0, and if you send me your edited version of this PR, I'll add it to my local branches too :)

ddcc4 pushed a commit that referenced this pull request May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants