Skip to content

fix(hardware-testing): handle non-Location locs#18345

Merged
sfoster1 merged 1 commit intoedgefrom
fix-hardware-testing-lint
May 14, 2025
Merged

fix(hardware-testing): handle non-Location locs#18345
sfoster1 merged 1 commit intoedgefrom
fix-hardware-testing-lint

Conversation

@sfoster1
Copy link
Copy Markdown
Member

@sfoster1 sfoster1 commented May 14, 2025

This wasn't handling the return values of this method properly, now it is.

@sfoster1
fix(hardware-testing): handle non-Location locs
8476e3d 
This wasn't handling the return values of this method properly, now it is.
@sfoster1 sfoster1 requested a review from a team as a code owner May 14, 2025 13:46
jbleon95
jbleon95 approved these changes May 14, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@jbleon95 jbleon95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, this slipped through cause of #18268. Thanks for catching and fixing this

@sfoster1 sfoster1 merged commit 9219014 into edge May 14, 2025
12 checks passed
@sfoster1 sfoster1 deleted the fix-hardware-testing-lint branch May 14, 2025 16:30
ddcc4 pushed a commit that referenced this pull request May 17, 2025
@sfoster1 @ddcc4
fix(hardware-testing): handle non-Location locs (#18345)
42cace0 
This wasn't handling the return values of this method properly, now it
is.
@ddcc4 ddcc4 mentioned this pull request May 17, 2025
Merged
ddcc4 pushed a commit that referenced this pull request May 17, 2025
@sfoster1 @ddcc4
fix(hardware-testing): handle non-Location locs (#18345)
c236aac 
This wasn't handling the return values of this method properly, now it
is.
ddcc4 pushed a commit that referenced this pull request May 17, 2025
@sfoster1 @ddcc4
fix(hardware-testing): handle non-Location locs (#18345)
f5bbbb2 
This wasn't handling the return values of this method properly, now it
is.

(cherry picked from commit 9219014)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
@sfoster1 @ddcc4
fix(hardware-testing): handle non-Location locs (#18345)
5d108a0 
This wasn't handling the return values of this method properly, now it
is.

(cherry picked from commit 9219014)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
@sfoster1 @ddcc4
fix(hardware-testing): handle non-Location locs (#18345)
c040b41 
This wasn't handling the return values of this method properly, now it
is.

(cherry picked from commit 9219014)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
@sfoster1 @ddcc4
fix(hardware-testing): handle non-Location locs (#18345)
65b2a3c 
This wasn't handling the return values of this method properly, now it
is.

(cherry picked from commit 9219014)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
@sfoster1 @ddcc4
fix(hardware-testing): handle non-Location locs (#18345)
e787595 
This wasn't handling the return values of this method properly, now it
is.

(cherry picked from commit 9219014)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
@sfoster1 @ddcc4
fix(hardware-testing): handle non-Location locs (#18345)
aab9b5c 
This wasn't handling the return values of this method properly, now it
is.

(cherry picked from commit 9219014)
ddcc4 pushed a commit that referenced this pull request May 19, 2025
@sfoster1 @ddcc4
fix(hardware-testing): handle non-Location locs (#18345)
c10d397 
This wasn't handling the return values of this method properly, now it
is.

(cherry picked from commit 9219014)
ddcc4 pushed a commit that referenced this pull request May 19, 2025
@sfoster1 @ddcc4
fix(hardware-testing): handle non-Location locs (#18345)
c4ac3cc 
This wasn't handling the return values of this method properly, now it
is.

(cherry picked from commit 9219014)
ddcc4 pushed a commit that referenced this pull request May 19, 2025
@sfoster1 @ddcc4
fix(hardware-testing): handle non-Location locs (#18345)
f18cfd1 
This wasn't handling the return values of this method properly, now it
is.

(cherry picked from commit 9219014)
ddcc4 pushed a commit that referenced this pull request May 20, 2025
@sfoster1 @ddcc4
fix(hardware-testing): handle non-Location locs (#18345)
4177a38 
This wasn't handling the return values of this method properly, now it
is.

(cherry picked from commit 9219014)
ddcc4 pushed a commit that referenced this pull request May 20, 2025
@sfoster1 @ddcc4
fix(hardware-testing): handle non-Location locs (#18345)
fd160cc 
This wasn't handling the return values of this method properly, now it
is.

(cherry picked from commit 9219014)
ddcc4 pushed a commit that referenced this pull request May 22, 2025
@sfoster1 @ddcc4
fix(hardware-testing): handle non-Location locs (#18345)
7c1d42e 
This wasn't handling the return values of this method properly, now it
is.

(cherry picked from commit 9219014)
ddcc4 pushed a commit that referenced this pull request May 23, 2025
@sfoster1 @ddcc4
fix(hardware-testing): handle non-Location locs (#18345)
9566b11 
This wasn't handling the return values of this method properly, now it
is.

(cherry picked from commit 9219014)
ddcc4 pushed a commit that referenced this pull request May 24, 2025
@sfoster1 @ddcc4
fix(hardware-testing): handle non-Location locs (#18345)
b135658 
This wasn't handling the return values of this method properly, now it
is.

(cherry picked from commit 9219014)
ddcc4 pushed a commit that referenced this pull request May 24, 2025
@sfoster1 @ddcc4
fix(hardware-testing): handle non-Location locs (#18345)
c0e95b8 
This wasn't handling the return values of this method properly, now it
is.

(cherry picked from commit 9219014)
ddcc4 pushed a commit that referenced this pull request May 29, 2025
@sfoster1 @ddcc4
fix(hardware-testing): handle non-Location locs (#18345)
9816421 
This wasn't handling the return values of this method properly, now it
is.

(cherry picked from commit 9219014)
ddcc4 pushed a commit that referenced this pull request May 29, 2025
@sfoster1 @ddcc4
fix(hardware-testing): handle non-Location locs (#18345)
bdc85b4 
This wasn't handling the return values of this method properly, now it
is.

(cherry picked from commit 9219014)
ddcc4 pushed a commit that referenced this pull request May 29, 2025
@sfoster1 @ddcc4
fix(hardware-testing): handle non-Location locs (#18345)
f0c3ccc 
This wasn't handling the return values of this method properly, now it
is.

(cherry picked from commit 9219014)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbleon95 jbleon95 jbleon95 approved these changes

@andySigler andySigler Awaiting requested review from andySigler

@ryanthecoder ryanthecoder Awaiting requested review from ryanthecoder

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sfoster1 @jbleon95